Feature/postgres database #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viklund
requested changes
Mar 8, 2019
There was a problem hiding this comment.
scripts/importer/data_importer/old_db.py: Why keep this around in the repo? It's in the history anyway.
scripts/importer/requirements.txt: Is there any point of having an extra requirements.txt file for the import scripts or would the main one for the repo be enough?
…tgresqlExtDatabase
Removes dbSNP and OMIM data, as we felt that they did not contribute enough to the system.
Adds indexes to beacon schema, changes views to work with changes in the data schema, and adds beacon schema to docker-compose.
Also avoid recalculation of identical data structure
Attempt to get code to work: don't reference data before it is created
norling
force-pushed
the
feature/postgres-database
branch
from
129befd
to
46eb946
Compare
talavis
force-pushed
the
feature/postgres-database
branch
from
dd24ced
to
e35c557
Compare
- check batch size using >= - check if batch: instead of if len(batch): - no need to reset batch at end - a few formatting changes
viklund
approved these changes
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request:
Pull request long description:
Replace Mysql with Postgres for e.g. user management.
Includes scripts and schema to replace mongo with postgres, though the browser changes required will be a separate pull request.
Changes made:
A lot. And more.