Add possibility of registered access for file download #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also a few missing returns after send_error.
|
Bypassing security using |
viklund
approved these changes
Apr 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request:
Pull request long description:
Make it possible to skip the
Access requested/Access grantedstep for datasets that havefile_accessset toRegistered. Registering an account will be enough for access. File access have been updated as well.Changes made:
User.has_accessnow checks the property offile_accessas well. Function calls updated to include version as parameter.Related issues:
The file uris in the database table
data.dataset_filesmust be updated to include/versions/<ds_version>/to support the changes made here.note:
/versions/matches the other API paths inbackend/route.py, butbackend/modules/browser/route.pyand the frontend are using/version/. Maybe change the API paths for all entries inbackend/route.pyto/versioninstead?