New error handling for browser #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotFoundError - no hits in db or similar ParsingError - unable to parse request (e. g. bad region) MalformedRequest - other error, currently only too large region
Perform a lookup of the variant to match other queries with no results found.
talavis
force-pushed
the
feature/new-exceptions
branch
from
d37252d
to
70d75fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request:
Pull request long description:
Most error handling in the browser now uses three exceptions:
NotFoundError- no hits in db or similarParsingError- unable to parse request (e. g. bad region)MalformedRequest- other error, currently only too large regionAlso fixed a couple of problems that were noted during updates for the new exceptions.
Also a few changes visible in frontend: