Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split parse rows from insert_variants #594

Merged
merged 2 commits into from
Aug 21, 2019
Merged

Split parse rows from insert_variants #594

merged 2 commits into from
Aug 21, 2019

Conversation

talavis
Copy link
Contributor

@talavis talavis commented Aug 20, 2019

Describe the pull request:

  • Bug fix
  • Functional change
  • New feature
  • Code cleanup
  • Build system change
  • Documentation change
  • Language translation

Pull request long description:

Split row parsing from insert_variants. Also some changes to batch data structure etc.

viklund
viklund approved these changes Aug 20, 2019
View reviewed changes
Copy link
Member

@viklund viklund left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just wrong:

rsids = [None]

@talavis talavis merged commit d621acc into develop Aug 21, 2019
@talavis talavis deleted the variant-importer-refactor branch August 21, 2019 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viklund viklund viklund approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@talavis @viklund