Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fortran standards bug-fixes #619

Merged
merged 22 commits into from Feb 13, 2024
Merged

Fortran standards bug-fixes #619

merged 22 commits into from Feb 13, 2024

Commits on Jan 11, 2024

  1. Removed the f2kcli module and all uses of it in the DART code. This m…

    …odule defined its own subroutines for COMMAND_ARGUMENT_COUNT() and GET_COMMAND_ARGUMENT() that called iargc and getarg.
    
    The only files that used this module were models/wrf/WRF_DART_utilities/add_pert_where_high_refl.f90 and DART/models/wrf/WRF_DART_utilities/grid_refl_obs.f90
    mjs2369 authored and hkershaw-brown committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    461924c View commit details
    Browse the repository at this point in the history
  2. Replaced the use of iargc and getarg with Fortran instrisics COMMAND_…

    …ARGUMENT_COUNT() and GET_COMMAND_ARGUMENT() in all possible locations in the code (models/wrf/WRF_DART_utilities/advance_cymdh.f90, observations/obs_converters/AVISO/convert_aviso.f90, and multiple files in observations/obs_converters/NCEP/prep_bufr/convert_bufr/)
    
    Removed declaration of the variable for iargc where unused in the code (models/wrf/WRF_BC/pert_wrf_bc.f90 and models/wrf/WRF_BC/update_wrf_bc.f90)
    mjs2369 authored and hkershaw-brown committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    f0d3337 View commit details
    Browse the repository at this point in the history
  3. Simplifies the implementation for summing the number of elements in t…

    …he CH_NETRT array that are greater than or equal to 0 by using the count function
    mjs2369 authored and hkershaw-brown committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    d92d5d9 View commit details
    Browse the repository at this point in the history
  4. Changed the random seed variables (iseed1 and iseed2) in the pert_sou…

    …nding_module (wrf) from real to integer types
    mjs2369 authored and hkershaw-brown committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    e813ef3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    40894e0 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Configuration menu
    Copy the full SHA
    69f6861 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. Creating specific mkmf.templates for the observation converters AIRS …

    …and quikscat because they use specific configurations with the HDF and/or RTTOV libraries. Versions created for both the gfortran and ifort compilers; the templates that use gfortran make use of the -fallow-argument-mismatch flag to fix type mismatch errors in JPL code
    mjs2369 committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    5338f78 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Updating the quikscat documentation to use Derecho paths, include all…

    … the necessary library flags, and point to the available mkmf.template files
    mjs2369 committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    1e4549c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f5df498 View commit details
    Browse the repository at this point in the history
  3. Remove / at the start of the paths to mkmf.template files from docume…

    …ntation in QuikSCAT.rst
    
    Co-authored-by: Helen Kershaw <20047007+hkershaw-brown@users.noreply.github.com>
    mjs2369 and hkershaw-brown committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    272c2cb View commit details
    Browse the repository at this point in the history
  4. Adjust wording in documentation in QuikSCAT.rst

    Co-authored-by: Helen Kershaw <20047007+hkershaw-brown@users.noreply.github.com>
    mjs2369 and hkershaw-brown committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    b44fd35 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9b17845 View commit details
    Browse the repository at this point in the history
  6. Removing changes to AIRS documentation from this PR; the entirety of …

    …the AIRS documentation will be cleaned/fixed in an upcoming pull request
    
    Co-authored-by: Helen Kershaw <20047007+hkershaw-brown@users.noreply.github.com>
    mjs2369 and hkershaw-brown committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    3e72e58 View commit details
    Browse the repository at this point in the history
  7. Remove large compiler doc sections from mkmf.template.quikscat.gfortran

    Co-authored-by: Helen Kershaw <20047007+hkershaw-brown@users.noreply.github.com>
    mjs2369 and hkershaw-brown committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    e33bc8a View commit details
    Browse the repository at this point in the history
  8. Remove large compiler doc sections from mkmf.template.AIRS.gfortran

    Co-authored-by: Helen Kershaw <20047007+hkershaw-brown@users.noreply.github.com>
    mjs2369 and hkershaw-brown committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    a8d38e8 View commit details
    Browse the repository at this point in the history
  9. Using /opt/local for NETCDF path mkmf.template.AIRS.gfortran , consis…

    …tent with other templates and usable with macports
    
    Co-authored-by: Helen Kershaw <20047007+hkershaw-brown@users.noreply.github.com>
    mjs2369 and hkershaw-brown committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    37dce3f View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. Removing the changes to NCEP/prep_bufr code, which will be addressed …

    …in a separate issue for updating and testing the prep_bufr code
    mjs2369 committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    6e094e1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7561c0f View commit details
    Browse the repository at this point in the history
  3. Remove svn line from mkmf.template.quikscat.intel

    Co-authored-by: Helen Kershaw <20047007+hkershaw-brown@users.noreply.github.com>
    mjs2369 and hkershaw-brown committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    31cb30f View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. Configuration menu
    Copy the full SHA
    af51471 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Configuration menu
    Copy the full SHA
    f17fa3e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dc12693 View commit details
    Browse the repository at this point in the history