-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix obs_diag ranked histogram documentation links #695
Conversation
Thanks Charlotte, the fix looks good. The obs_diag pages all have a broken link to 'ncview' at the bottom of each page, I'll switch this out with the working link since I'm squashing. This is out of scope for this request, but there is loads of repeated documentation between these pages: PROGRAM obs_diag (for 1D observations) |
fix broken link to ncview in text
899fc28
to
e149f84
Compare
removed underscores from anchor, rst seemed to not like these see https://github.com/NCAR/DART/pull/695/files#r1668667022 and https://github.com/NCAR/DART/pull/695/files#r1668706724 for discusion link to anchor rather than hardoded html page.
@c-merchant I switched out the hardcoded links from https://docs.dart.ucar.edu/en/latest/guide/matlab-observation-space.html to the anchor for Cheers |
@hkershaw-brown Got it. I checked the links, and they look good to go! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Charlotte!
Description:
This is a fix to the documentation links for guidance on creating ranked histograms with ncview and matlab for threed_cartesian and threed_sphere obs_diag. They link to the documentation for ncview and the guide on analyzing observation space with MATLAB.
Fixes issue
Issue #657
Types of changes
Documentation changes needed?
Tests
I built and ran the DART documentation locally with Sphinx and ran the classic ./quickbuild.sh to make sure things hadn't been thrown off.
Checklist for merging
Checklist for release
Testing Datasets