Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing probabilistic data through Python embedding does not work. #1210

Closed
JohnHalleyGotway opened this issue Oct 17, 2019 · 1 comment
Closed
Assignees
Labels

Comments

@JohnHalleyGotway
Copy link
Collaborator

This issue was raised via MET-Help:
https://rt.rap.ucar.edu/rt/Ticket/Display.html?id=92694

The user passed data with python embedding to Point-Stat and set "prob = TRUE;" in the config file, but no probabilistic output was produced.

The problem existing in the VarInfoPython::set_dict() function in var_info_python.cc. It fails to parse the "prob" setting from the input dictionary.

In the master_v8.1 bugfix branch (for met-8.1.2), fix this by updating that function in the python library.

In the develop branch (for met-9.0), fix this by factoring the parsing of "prob" output from the derived libraries (vx_data2d_grib, vx_data2d_grib2, vx_data2d_python, vx_data2d_nc_met, vx_data2d_nccf, vx_data2d_nccf) and do it once in the base class (VarInfo::set_dict()) instead.

@JohnHalleyGotway JohnHalleyGotway added type: bug Fix something that is not working component: library code requestor: Community General Community labels Oct 17, 2019
@JohnHalleyGotway JohnHalleyGotway added this to the MET 8.1.2 (bugfix) milestone Oct 17, 2019
@JohnHalleyGotway JohnHalleyGotway self-assigned this Oct 17, 2019
JohnHalleyGotway added a commit that referenced this issue Oct 17, 2019
…the derived classes up to one spot in the base class. This fixes bugfix: #1210
@JohnHalleyGotway
Copy link
Collaborator Author

Fixed in master_v8.1 and the develop branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant