Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsmall no longer opens #2273

Closed
StasJ opened this issue Apr 10, 2020 · 1 comment
Closed

jsmall no longer opens #2273

StasJ opened this issue Apr 10, 2020 · 1 comment
Assignees
@clyne
Labels
Bug Fixed High
Milestone
3_3_0 release

Comments

@StasJ
Copy link
Collaborator

StasJ commented Apr 10, 2020

If you try opening jsmall (I am using the most recent VDC version on little_glade) you get the following error:

Failure to open data set of type "vdc"
Failed to initialize horizontal coordinates
Failed to initialize derived coord variable
Invalid variable "Cs_r"

On OSX.
@StasJ StasJ added the Bug label Apr 10, 2020
@clyne clyne self-assigned this Apr 14, 2020
@clyne
Copy link
Collaborator

clyne commented Apr 14, 2020

This issue has been partially fixed by PR #2277. However, the fix only works for VDC files generated after #2277. Older VDC files will still not open.

@clyne clyne added the High label Apr 14, 2020
clyne added a commit that referenced this issue Apr 16, 2020
@clyne
Fixed #2273
4475386
@clyne clyne closed this as completed in 744ee14 Apr 16, 2020
StasJ added a commit that referenced this issue Jul 30, 2020
@StasJ
Squashed commit of the following:
62a79ba 
commit e0d7594
Author: Scott Pearse <pearse@ucar.edu>
Date:   Thu Jul 30 09:32:48 2020 -0600

    write warning test failure to circle output upon failure

commit bb53927
Merge: 43aa394 805f7e2
Author: Stanislaw Jaroszynski <stas708@gmail.com>
Date:   Mon Jul 27 12:05:04 2020 -0600

    Merge branch 'master' of https://github.com/NCAR/VAPOR

commit 43aa394
Author: Samuel Li <shaomeng@ucar.edu>
Date:   Mon Jul 27 12:00:03 2020 -0600

    fix git blame

commit 805f7e2
Author: StasJ <StasJ@users.noreply.github.com>
Date:   Mon Jul 27 07:40:00 2020 -0600

    Fix GUI coloring (#2320)

commit f4bc6c5
Author: StasJ <StasJ@users.noreply.github.com>
Date:   Sat Jul 25 13:25:22 2020 -0600

    Fix misc qt cmake issues (#2319)

commit a442ed0
Author: Scott Pearse <pearse@ucar.edu>
Date:   Wed Jul 8 09:00:55 2020 -0600

    Fix unguarded if clauses

commit 94b1708
Author: Scott Pearse <pearse@ucar.edu>
Date:   Wed Jul 8 08:41:28 2020 -0600

    re-enable warning/smoke tests on master

commit 05ebe5b
Author: Scott Pearse <pearse@ucar.edu>
Date:   Wed Jul 8 08:31:18 2020 -0600

    Disable manual release builds on master

commit eed3605
Author: Scott Pearse <pearse@ucar.edu>
Date:   Wed Jul 8 08:15:12 2020 -0600

    turn off weekly builds on master branch, which causes them to trigger on each PR

commit 59c3322
Author: sgpearse <pearse@ucar.edu>
Date:   Fri Jun 26 16:46:11 2020 -0600

    Fix unused function warning (#2302)

    * Fix unused function warning

    * ifdef unused function instead of deleting it

commit 27e10f5
Author: Scott Pearse <pearse@ucar.edu>
Date:   Fri Jun 26 06:00:25 2020 -0600

    rerun weekly build

commit ed79f29
Author: Scott Pearse <pearse@ucar.edu>
Date:   Fri Jun 26 05:57:48 2020 -0600

    Fix osx library link

commit 8a44bb9
Author: sgpearse <pearse@ucar.edu>
Date:   Wed Jun 24 17:17:53 2020 -0600

    Issue1701 (#2304)

    * incremental

    * Undo clearing of VaporTable

commit 54db3b7
Merge: 669a896 a9d19c5
Author: Scott Pearse <pearse@ucar.edu>
Date:   Wed Jun 24 08:42:20 2020 -0600

    Merge branch 'master' of https://github.com/NCAR/VAPOR

commit 669a896
Author: Scott Pearse <pearse@ucar.edu>
Date:   Wed Jun 24 08:31:08 2020 -0600

    update circle config

commit a9d19c5
Author: StasJ <StasJ@users.noreply.github.com>
Date:   Tue Jun 23 08:43:52 2020 -0600

    Flow rendering refactor (#2280)

    * Flow rendering refactor

    * fix

    * Address GUI review comments

    * changes from second gui review meeting

    * Added documentation to shaders

    * Made var private

    * misc

    * misc

    * Line width

    * remove goto

commit 961ce70
Author: Stanislaw Jaroszynski <stas708@gmail.com>
Date:   Mon Jun 22 16:48:00 2020 -0600

    Casper fix

commit ac1c64b
Author: sgpearse <pearse@ucar.edu>
Date:   Sat Jun 6 08:13:46 2020 -0600

    Fix dbus (#2300)

    * Fix dbus problem on CentOS

    * Fix dbus

commit 9f6636d
Author: sgpearse <pearse@ucar.edu>
Date:   Fri May 29 13:02:40 2020 -0600

    fix #2295: wrong linker symbol in libvdc (#2296)

commit 8a1fef8
Author: clyne <clyne@ucar.edu>
Date:   Tue May 19 14:56:12 2020 -0600

    Fixed #2276 - Add support for deriving zonal and meridional winds for MPAS model outputs (#2290)

    * Fixed #2276

    * Fixed memory leak

    * Check return code

commit 77f5869
Author: Scott Pearse <pearse@ucar.edu>
Date:   Wed May 13 08:00:58 2020 -0600

    Point users to discourse forum

commit dc160bb
Merge: 8be32f5 661a966
Author: Scott Pearse <pearse@ucar.edu>
Date:   Tue May 12 09:05:01 2020 -0600

    Merge branch 'master' of https://github.com/NCAR/VAPOR

commit 8be32f5
Author: Scott Pearse <pearse@ucar.edu>
Date:   Tue May 12 09:04:55 2020 -0600

    added space to circle

commit 661a966
Author: Orhan Eroglu <32553057+erogluorhan@users.noreply.github.com>
Date:   Tue May 12 06:22:22 2020 -0600

    game the system (#2293)

commit 15734b4
Author: Kevin Hallock <khallock@users.noreply.github.com>
Date:   Fri May 8 11:06:19 2020 -0600

    Add weekly build info to downloads.html (#2292)

commit e0592a5
Author: Scott Pearse <pearse@ucar.edu>
Date:   Fri May 8 06:57:16 2020 -0600

    gameTheSystem

commit ff7640f
Author: sgpearse <pearse@ucar.edu>
Date:   Sat May 2 10:03:13 2020 -0600

    Removed static_cast in c file (#2291)

commit 8dfa913
Author: sgpearse <pearse@ucar.edu>
Date:   Thu Apr 30 14:18:13 2020 -0600

    Ubuntu warnings (#2289)

    * Fix warnings

    * fix warnings

commit 2e2dcfe
Author: sgpearse <pearse@ucar.edu>
Date:   Wed Apr 22 15:33:00 2020 -0600

    Smoke tests (#2238)

    * test

    * test

    * test

    * test

    * test

    * test

    * test

    * test

    * test

    * test

    * test

    * test

    * ghr test

    * fix

    * test

    * save to workspace

    * save to workspace

    * save to workspace

    * test

    * test

    * test

    * test

    * test

    * test

    * test

    * test

    * test

    * test

    * test

    * test

    * test

    * test

    * test

    * test

    * test

    * test

    * test

    * osx test

    * osx test

    * Hopefully fixed CPack on OSX

    * test

    * test

    * open floodgates

    * adding cron

    * adding cron

    * adding cron

    * modified cron

    * modified cron

    * Vapor3 nightly build for installers

    * Vapor3 nightly build for installers

    * Vapor3 nightly build for installers

    * fixed timing of cron job to correspond to UTC

    * valgrind test

    * valgrind test

    * valgrind test

    * valgrind test

    * valgrind test

    * valgrind test

    * valgrind test

    * Updated nightly-release description

    * Clang tidy

    * fix schema

    * remove sudo

    * tidy

    * osx test for clang-tidy

    * osx test for clang-tidy

    * osx test for clang-tidy

    * osx test for clang-tidy

    * osx test for clang-tidy

    * osx test for clang-tidy

    * osx test for clang-tidy

    * osx test for clang-tidy

    * osx test for clang-tidy

    * clang-tidy on ubuntu

    * clang-tidy on ubuntu

    * clang-tidy on ubuntu

    * clang-tidy on ubuntu

    * clang-tidy on ubuntu

    * clang-tidy on ubuntu

    * clang-tidy on ubuntu

    * osx cache test

    * osx cache test

    * osx cache test

    * osx cache test

    * osx cache test

    * osx cache test

    * Added script for osx

    * Added script for osx

    * Added script for osx

    * Added script for osx

    * Added script for osx

    * Added script for osx

    * Added script for osx

    * Added script for osx

    * Added script for osx

    * Added script for osx

    * OSX and win10 test

    * OSX and win10 test

    * OSX and win10 test

    * OSX and win10 test

    * OSX and win10 test

    * OSX and win10 test

    * installer cache test

    * installer cache test

    * installer cache test

    * installer cache test

    * installer cache test

    * installer cache test

    * increase timeout

    * Windows10 test

    * win10 test

    * win10 test

    * win10 test

    * win10 test

    * win10 test

    * win10 test

    * first commit

    * win10 test

    * win10 test

    * win10 test

    * win10 test

    * win10 test

    * win10 test

    * win10 test

    * win10 test

    * win10 test

    * win10 test

    * win10 test

    * win10 test

    * win10 test

    * win10 test

    * win10 test

    * windows10 persist to workspace

    * win10 workspace test

    * win10 workspace test

    * win10 workspace test

    * win10 workspace test

    * win10 workspace test

    * win10 workspace test

    * win10 workspace test

    * win10 workspace test

    * win10 workspace test

    * win10 workspace test

    * win10 workspace test

    * win10 workspace test

    * test

    * test

    * manual run of weekly build

    * reinstate weekly buildsw

    * reinstate weekly builds

    * update

    * Removed caching on OSX

    * Test synthetic grids

    * Changed names of nightly builds to weekly

    * incremental

    * test

    * test

    * incremental

    * manual weekly build

    * manual weekly build

    * ready for PR

    * Removed files

    * Removed files

    * Removed comments

    * Removed comment

    * Win10 test

    * Added descriptions

    * ghr test

    * ghr test

    * ghr test

    * ghr test

    * ghr test

    * ghr test

    * ghr test

    * ghr test

    * test

    * test

    * test

    * save dockerfile before stash

    * updates for clarifying nudge bug

    * removed diagnostic

    * smokeTest+Circle test

    * Fixed #2252

    * intermediate

    * added default baseline file generation

    * Added baseline files

    * updated baseline files, but there's a new bug

    * update dockerfile

    * test

    * Incremental

    * test

    * test

    * test

    * test

    * Remove grid test baseline files

    * Added python to ubuntu18 docker image

    * Add python

    * test

    * test

    * test

    * test

    * test

    * test

    * test

    * test

    * incremental

    * updates

    * Added ConstCoordItr and ConstNodeItr tests

    * test

    * indexing fix

    * Added margin of error to iterator tests

    * updates for code review

    * Added guards to if() statements

    * Change from AccessIJK to GetValueAtIndex

    * moved t0 up with other initializers

    * update baseline files

    Co-authored-by: John Clyne <clyne@ucar.edu>

commit da1cb4d
Author: clyne <clyne@ucar.edu>
Date:   Tue Apr 21 08:03:53 2020 -0600

    Fixed #2285 (#2286)

commit 00ac696
Author: StasJ <StasJ@users.noreply.github.com>
Date:   Sun Apr 19 14:22:43 2020 -0600

    Change extension from .nc to .vdc (#2262)

    * Change extension from .nc to .vdc

    * warning

    * Change message output to stderr

    * Vapor command line arguments

    * Help message

    * Automatically determine dataset format

    * Change from return code to boolean

commit 2612810
Author: Scott Pearse <pearse@ucar.edu>
Date:   Fri Apr 17 08:34:01 2020 -0600

    Update third party libraries

commit 744ee14
Author: clyne <clyne@ucar.edu>
Date:   Wed Apr 15 20:07:58 2020 -0600

    Fixed #2273 - jsmall no longer opens (#2282)

    * Fixed #2273

    * Accidentally omitted changes to .h file.

commit abf3388
Author: sgpearse <pearse@ucar.edu>
Date:   Wed Apr 15 18:20:21 2020 -0600

    Upgrade to Qt 5.13.2 - Issue 2247 (#2271)

    * initial commit

    * added build3rdParty.py

    * Ubuntu mods

    * CentOS updates

    * OSX updates

    * OSX updates

    * updates

    * Ubuntu update

    * Removed script

    * windows update

    * Fix PRegionSelector warning

commit 76a878a
Author: clyne <clyne@ucar.edu>
Date:   Tue Apr 14 08:45:14 2020 -0600

    Fixed #2274 (#2275)
@clyne clyne added the Fixed label Dec 16, 2020
@clyne clyne added this to the 3_3_0 release milestone Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clyne clyne

Labels
Bug Fixed High
Projects
None yet
Milestone
3_3_0 release
Development

No branches or pull requests
2 participants
@StasJ @clyne