Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smoke tests failing on 1D and 2D grids #2708

Closed
sgpearse opened this issue Apr 21, 2021 · 3 comments · Fixed by #2902
Closed

Smoke tests failing on 1D and 2D grids #2708

sgpearse opened this issue Apr 21, 2021 · 3 comments · Fixed by #2902
Assignees
@clyne
Labels
Bug High
Milestone
3_6_0 Release

Comments

@sgpearse
Copy link
Collaborator

sgpearse commented Apr 21, 2021 •
edited
Loading

Our grid tests are failing on 1D and 2D grids due to assertions that grid dimension lengths need to be > 0.

To reproduce, check out main, build Vapor with test_apps=ON, and run the following grid tests:

- VAPOR/build/bin/testGrid -dims 1x1x1
- VAPOR/build/bin/testGrid -dims 1x8x8
- VAPOR/build/bin/testGrid -dims 8x1x8
- VAPOR/build/bin/testGrid -dims 8x8x1

  • VAPOR/build/test_binaries/testGrid -dims 1x1x1
  • VAPOR/build/test_binaries/testGrid -dims 1x8x8
  • VAPOR/build/test_binaries/testGrid -dims 8x1x8
  • VAPOR/build/test_binaries/testGrid -dims 8x8x1
@sgpearse sgpearse added the Bug label Apr 21, 2021
@clyne clyne added the High label May 11, 2021
@clyne
Copy link
Collaborator

clyne commented Jun 17, 2021

@sgpearse will re-verify, and then we can assess if to make a milestone.

@sgpearse sgpearse self-assigned this Nov 9, 2021
@sgpearse sgpearse added this to the 3_6_0 Release milestone Nov 9, 2021
@sgpearse
Copy link
Collaborator Author

1x1x1 - Seems to be in an infinite loop. Killed after 20 minutes of run time.
1x8x8 - Pass
8x1x8 - Pass
8x8x1 - Pass

*note that the testGrid binary is now in VAPOR/build/test_binaries

clyne added a commit that referenced this issue Nov 12, 2021
@clyne
Fixed #2708
767d4b8
@clyne clyne mentioned this issue Nov 12, 2021
Merged
@clyne clyne assigned clyne and unassigned sgpearse Nov 30, 2021
clyne added a commit that referenced this issue Dec 2, 2021
@clyne
Issue 2708 - Smoke tests failing on 1D and 2D grids (#2902)
5efbe80 
* Fixed #2708

* clang-format pre-push hook
@sgpearse sgpearse reopened this Feb 4, 2022
@sgpearse
Copy link
Collaborator Author

sgpearse commented Feb 4, 2022

1x8x8 fails tests for Regular, Stretched, and Layered grids, then dumps core when testing Curvilinear.
8x1x8 fails all tests.

1x1x1 and 8x8x1 pass all tests.

clyne added a commit that referenced this issue Feb 7, 2022
@clyne
Fixed #2708 - Smoke tests failing on 1D and 2D grids
64a975a
@clyne clyne closed this as completed in 76487dd Feb 7, 2022
clyne added a commit that referenced this issue Feb 7, 2022
@clyne
Revert "Fixed #2708 - Smoke tests failing on 1D and 2D grids (#2994)"
49e1cdf 
This reverts commit 76487dd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clyne clyne

Labels
Bug High
Projects
None yet
Milestone
3_6_0 Release
Development

Successfully merging a pull request may close this issue.

Issue 2708 - Smoke tests failing on 1D and 2D grids NCAR/VAPOR
2 participants
@clyne @sgpearse