Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DC classes leak memory #2817

Closed
shaomeng opened this issue Jul 22, 2021 · 1 comment · Fixed by #2892
Closed

DC classes leak memory #2817

shaomeng opened this issue Jul 22, 2021 · 1 comment · Fixed by #2892
Assignees
Milestone

Comments

@shaomeng
Copy link
Collaborator

DCBOV leaks memory when the initialize() function called the second time and a brand new BOVCollection object is created. The old BOVCollection object is leaked.

VAPOR/lib/vdc/DCBOV.cpp

Lines 36 to 40 in 48241d0

int DCBOV::initialize(const vector<string> &paths, const std::vector<string> &options)
{
_bovCollection = new BOVCollection();
int rc = _bovCollection->Initialize(paths);

Per @sgpearse , this problem isn't limited to DCBOV class.

@sgpearse
Copy link
Collaborator

The DCBOV class fixes this by just checking the Collection pointer and deleting it if necessary. But the problem still exists in other DC classes (DCCF, DCMPAS, DCWRF, etc).

@sgpearse sgpearse changed the title DCBOV leaks memory DC classes leaks memory Jul 22, 2021
@sgpearse sgpearse changed the title DC classes leaks memory DC classes leak memory Jul 22, 2021
@clyne clyne self-assigned this Nov 3, 2021
clyne added a commit that referenced this issue Nov 3, 2021
clyne added a commit that referenced this issue Nov 3, 2021
@sgpearse sgpearse added this to the 3_6_0 Release milestone Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants