Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems switching barb or flow renderer between 2D and 3D variables #2899

Closed
clyne opened this issue Nov 11, 2021 · 6 comments · Fixed by #2960 or #2998
Closed

Problems switching barb or flow renderer between 2D and 3D variables #2899

clyne opened this issue Nov 11, 2021 · 6 comments · Fixed by #2960 or #2998
Assignees
Milestone

Comments

@clyne
Copy link
Collaborator

clyne commented Nov 11, 2021

To reproduce:

  1. Load katrina and enable the barb renderer with 3D data (U,V,W variables). Hurricane Katrina data can be found here.
  2. Change variable selector from 3D to 2D (U10, V10 variables)
  3. Change the horizontal geometry sliders
  4. Switch back to 3D variables. Nothing will be drawn. Note that the upper extent of the Z coordinate on the Geometry tab is 0.0

Similar behavior occurs with flow renderer.

@clyne clyne added the Bug label Nov 11, 2021
@clyne clyne changed the title Problems switching barb renderer between 2D and 3D variables Problems switching barb or flow renderer between 2D and 3D variables Nov 11, 2021
@clyne clyne added the High label Nov 30, 2021
@clyne clyne added this to the 3_6_0 Release milestone Nov 30, 2021
StasJ added a commit that referenced this issue Jan 7, 2022
@StasJ StasJ added the Fixed label Jan 7, 2022
clyne pushed a commit that referenced this issue Jan 10, 2022
…variables (#2960)

* Fix #2899

* clang-format pre-push hook

* inc

* clang-format pre-push hook

* change to CoordType

* clang-format pre-push hook

* Remove zero extents check
@clyne
Copy link
Collaborator Author

clyne commented Jan 31, 2022

Now as soon as the variable selector is changed from 3D to 2D an error is thrown: extents of the selected variable are out of range.

@clyne clyne reopened this Jan 31, 2022
@clyne clyne unassigned StasJ Feb 1, 2022
@sgpearse
Copy link
Collaborator

sgpearse commented Feb 4, 2022

Bizarre note on this bug:

It only presents itself on installer builds. It does not present itself when running a source build regardless of setting Release or Debug mode.

Scratch that.

@sgpearse sgpearse assigned clyne and unassigned sgpearse Feb 4, 2022
@sgpearse
Copy link
Collaborator

sgpearse commented Feb 4, 2022

Seems to be a DataMgr regression, so I'll reassign to @clyne for now.

@clyne
Copy link
Collaborator Author

clyne commented Feb 4, 2022

@sgpearse what indication do you have that this is a problem with the DataMgr?

@sgpearse
Copy link
Collaborator

sgpearse commented Feb 5, 2022

@clyne - It's a bit of a rabbit hole.

The error message is coming form DataMgr.cpp:977. This is due to a return value of "1" from the function _find_bounding_grid(). I wish I knew how to copy/paste a sensible stack trace on github but formatting lldb's output makes GitHub choke.

My indication is through the following trace:

  1. Box::GetExtents() <-- This was recently modified on January 6, 2022
  2. RenderParams::GetMapperFunc()
  3. DataMgr::GetDataRange()
  4. DataMgr::_findbounding_grid()

To reproduce the trace:

  1. Build Vapor with debug flags
  2. Run it on OSX with lldb or your chosen debugger
  3. Set a breakpoint at DataMgr.cpp:2770
  4. Load any dataset and create/enable a barb renderer
  5. Change the dimensionality from 3D to 2D
  6. observe the stack trace with "bt" if using lldb

@clyne
Copy link
Collaborator Author

clyne commented Feb 8, 2022

Got it. Thanks.

clyne added a commit that referenced this issue Feb 8, 2022
clyne added a commit that referenced this issue Feb 8, 2022
… 3D variables (#2998)

* Fixed #2899 - Problems switching barb or flow renderer between 2D and 3D variables

* Fixed regression from PR #2994

* clang-format pre-push hook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment