Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slice + UGRID problem #2906

Closed
sgpearse opened this issue Nov 17, 2021 · 0 comments · Fixed by #2939
Closed

Slice + UGRID problem #2906

sgpearse opened this issue Nov 17, 2021 · 0 comments · Fixed by #2939
Assignees
@sgpearse
Labels
Bug High
Milestone
3_6_0 Release

Comments

@sgpearse
Copy link
Collaborator

Import the UGRID data in /glade/p/cisl/vast/vapor/data/Source/UGRID/NOAA-geoflow/small

Create a slice with the following rotation parameters:
X = -19.8
Y = 0
Z = 16.2

The slice will not be sampled properly and will stretch outside of the domain. Note that the Z stretch factor for this dataset is ~4 million.
@sgpearse sgpearse added the Bug label Nov 17, 2021
@sgpearse sgpearse self-assigned this Nov 17, 2021
@sgpearse sgpearse mentioned this issue Nov 17, 2021
Merged
@clyne clyne added the High label Nov 30, 2021
@clyne clyne added this to the 3_6_0 Release milestone Nov 30, 2021
This was referenced Dec 7, 2021
Closed
Closed
@sgpearse sgpearse mentioned this issue Dec 17, 2021
Merged
clyne pushed a commit that referenced this issue Jan 7, 2022
@sgpearse
Functional slice sampling implementation, and address UGRID problem #…
a1fb839 
…2906 (#2939)

* initial

* fix slice regression introduced by windows build fix

* inc

* inc

* inc

* GetGrid() and GetWindingOrder() seem to be working

* winding order now working

* cleanup

* revert gritTools.cpp

* fix 2906

* disable debug mode

* new sampler working with new winding order

* functional implementation SliceGridAlongPlane now working

* cleanup

* cleanup

* Remove old convex hull code

* edit cmakelists

* build installer

* build installer

* address comments

* move GTE to third-party libs

* test windows and osx with new third party libs

* Remove unused members and functions

* add windows macro

* revert config.yml

* turn off clang-format

* turn off clang-format

* Update datatypes from vectors to VAPoR::CoordType and VAPoR::DimsType

* Respecify slice as being a 3D grid instead of 2D, via VAPoR::DimsType

* re-enable clang-format and remove comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgpearse sgpearse

Labels
Bug High
Projects
None yet
Milestone
3_6_0 Release
Development

Successfully merging a pull request may close this issue.

Functional slice sampling implementation, and address UGRID problem #2906 NCAR/VAPOR
2 participants
@clyne @sgpearse