Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VDC version of CF NetCDF might be corrupt #2918

Closed
shaomeng opened this issue Nov 28, 2021 · 0 comments · Fixed by #2925
Closed

VDC version of CF NetCDF might be corrupt #2918

shaomeng opened this issue Nov 28, 2021 · 0 comments · Fixed by #2925
Assignees
@clyne
Labels
Bug High
Milestone
3_6_0 Release

Comments

@shaomeng
Copy link
Collaborator

shaomeng commented Nov 28, 2021 •
edited
Loading

Describe the bug

Volume rendering of native NetCDF CF file and VDC version of it don't agree. I suspect that VDC conversion might have corrupted the file, though there are other possible ways things go wrong...

To Reproduce

Steps to reproduce the behavior. For example:

  1. Use native NetCDF CF file /glade/work/shaomeng/cm1.nc and convert it to VDC format. Note that the conversion has problems with some variables (cf2vdc failed to copy certain variables #2917), but variable vortmag seems to be converted fine.
  2. Use volume rendering to render vortmag from the native file and from the VDC version of it.
  3. Adjust the color map so that the left-most control point has zero opacity. The resulting renderings look very differently. I think the native rendering which shows a clear tornado core is the correct one.

Screen Shot 2021-11-28 at 4 11 51 PM

Screen Shot 2021-11-28 at 4 10 45 PM
@shaomeng shaomeng added the Bug label Nov 28, 2021
@clyne clyne added the High label Nov 30, 2021
@clyne clyne added this to the 3_6_0 Release milestone Nov 30, 2021
@clyne clyne self-assigned this Nov 30, 2021
clyne added a commit that referenced this issue Dec 4, 2021
@clyne
Fixed #2917
d65fdd9 
Fixed #2918

Wrong virtual method picked up
@clyne clyne mentioned this issue Dec 4, 2021
Merged
clyne added a commit that referenced this issue Dec 4, 2021
@clyne
Fixes Issue 2917, 2918 - cf2vdc failed to copy certain variables (#2925)
a5b5009 
* Fixed #2917
Fixed #2918

Wrong virtual method picked up

* clang-format pre-push hook
@StasJ StasJ mentioned this issue Jan 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clyne clyne

Labels
Bug High
Projects
None yet
Milestone
3_6_0 Release
Development

Successfully merging a pull request may close this issue.

Fixes Issue 2917, 2918 - cf2vdc failed to copy certain variables NCAR/VAPOR
2 participants
@shaomeng @clyne