Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2799 - update AnimationParams upon loading data #2808

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Conversation

sgpearse
Copy link
Collaborator

@sgpearse sgpearse commented Jul 14, 2021

Fixes #2799 Fixes #2812 by setting the number of timesteps in AnimationParams upon loading data.

@sgpearse sgpearse requested a review from StasJ July 14, 2021 15:37
Copy link
Collaborator

@StasJ StasJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can still reproduce the bug on this branch.

@clyne
Copy link
Collaborator

clyne commented Jul 20, 2021

@StasJ please see if this PR fixes #2812, NOT #2799

@clyne clyne merged commit bf09fc3 into main Jul 20, 2021
@clyne clyne deleted the issue2799 branch July 20, 2021 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants