udpate smoke tests with zf variable #2847
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nate v variables. Previously a variable was identified as a coordinate variable only if it was referenced by a "data" variable. Now if a variable can be identified as a coordinate variable via the CF specification it is classified as a coordinate variable. Also simplified the DCCF class assignment of coordinate variables.
simple algorithm fails :-(
…s and time steps were stored in different NetCDF files. E.g. one variable, one time step per file.
range -180..180, and removed various hacks to handle this situation.
clyne
reviewed
Aug 13, 2021
There was a problem hiding this comment.
@sgpearse since we're making changes to these tests already, how about we add an option to silence the Elapsed time reporting so that we're not confronted with confusing diffs every time we need to change these regression tests?
clyne
approved these changes
Sep 14, 2021
This was referenced Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the zf coordinate variable to our smoke test baseline file for NetCDF-CF files.
Note - These baseline files were build without OpenMP. I'm currently experiencing linker errors when running from source with OpenMP. My installers are running fine though. Not sure what's going on at the moment.