Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix smoke tests in #2871 #2880

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Fix smoke tests in #2871 #2880

merged 1 commit into from
Oct 26, 2021

Conversation

sgpearse
Copy link
Collaborator

Redirect smoke test launcher to new the test directory, test_binaries.

@sgpearse sgpearse changed the title smoke test Fix smoke tests in #2871 Oct 26, 2021
@sgpearse sgpearse mentioned this pull request Oct 26, 2021
Merged
@shaomeng shaomeng merged commit 7151beb into issue_2871 Oct 26, 2021
shaomeng added a commit that referenced this pull request Nov 3, 2021
@shaomeng @sgpearse
fix #2871 by introducing additional directories (#2878)
15b7c55 
* fix #2871

* move test binaries to their own directory

* smoke test (#2880)

* fix review comments

* address review comments

Co-authored-by: Samuel Li <shaomeng@cisl-vapor>
Co-authored-by: sgpearse <pearse@ucar.edu>
clyne pushed a commit that referenced this pull request Nov 12, 2021
@shaomeng @sgpearse
fix Issue 2865 (#2883)
1391912 
* fix #2871

* move test binaries to their own directory

* smoke test (#2880)

* fix review comments

* fix #2865

* minor

* clang-format

Co-authored-by: Samuel Li <shaomeng@cisl-vapor>
Co-authored-by: sgpearse <pearse@ucar.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgpearse @shaomeng