Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow deltaT adjustment on thin volumes #3045

Merged
merged 4 commits into from
Feb 23, 2022
Merged

Flow deltaT adjustment on thin volumes #3045

merged 4 commits into from
Feb 23, 2022

Conversation

shaomeng
Copy link
Collaborator

fix #3008

@clyne clyne requested review from StasJ, sgpearse and clyne and removed request for sgpearse February 22, 2022 15:34
Copy link
Collaborator

@clyne clyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shaomeng something still isn't right here. If you set the Z component to 'none', the resulting stream lines are close to zero length. Increasing the integration count has no visible effect (other than the computation takes a lot longer). Perhaps if a velocity component is 'none' you should not be including the associated coordinate extent in the calculation of deltaT. E.g. If the Z component of velocity is set to 'none' then the Z extent of the domain should not be used in the calculation of deltaT.

@shaomeng
Copy link
Collaborator Author

If the Z component of velocity is set to 'none' then the Z extent of the domain should not be used in the calculation of deltaT.

@clyne This review comment has been addressed in d320d1f.

@shaomeng shaomeng requested a review from clyne February 23, 2022 01:40
@clyne
Copy link
Collaborator

clyne commented Feb 23, 2022

Getting closer, but I still can't get the integration to proceed beyond a very short distance when "Z field" is none, can you? Can you explain why this is happening?

@shaomeng
Copy link
Collaborator Author

Getting closer, but I still can't get the integration to proceed beyond a very short distance when "Z field" is none, can you? Can you explain why this is happening?

@clyne The variables v1 and v2 have mostly tiny values centered around zero, resulting in many "sinks" or near sinks, which are areas with zero or near-zero values. When a particle enters a such area, it makes small movements in the sink but can be almost impossible to escape. With a domain size of millions, those small movements appear invisible. For this particular data set, it appears that there are more sinks than non-sinks, so most particles fall in sinks after traveling a while.

@clyne clyne merged commit 524915a into main Feb 23, 2022
@clyne clyne deleted the issue_3008 branch February 23, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flow renderer doesn't work with some UGRID data
3 participants