Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3429: Jupyter kernel dies when it can't find data #3435

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Fix #3429: Jupyter kernel dies when it can't find data #3435

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/vapi/Session.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,10 @@ int Session::Render(String imagePath, bool fast)
LogWarning("Nothing to render");
return -1;
}
if (_controlExec->GetParamsMgr()->GetDataMgrNames() != getGUIStateParams()->GetOpenDataSetNames()) {
LogWarning("Cannot render: There are missing datasets");
return -1;
}

return _renderManager->Render(imagePath, fast);
}
Expand Down Expand Up @@ -238,9 +242,8 @@ void Session::loadAllParamsDatasets()
} else {
getGUIStateParams()->RemoveOpenDateSet(name);

string err = "This session links to the dataset " + name + " which was not found. Please open this dataset if it is in a different location";
string details = "This session links to the dataset " + name + " which was not found. Please open this dataset if it is in a different location\n";

string details;
for (const auto &path : paths)
if (!FileUtils::Exists(path)) details += "\"" + path + "\" not found.\n";

Expand Down