Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue3403 - reinstate smoke tests on SUSE #3491

Merged
merged 27 commits into from
Nov 28, 2023
Merged

Fix issue3403 - reinstate smoke tests on SUSE #3491

merged 27 commits into from
Nov 28, 2023

Conversation

sgpearse
Copy link
Collaborator

@sgpearse sgpearse commented Nov 7, 2023

This reinstates the smoke tests that were previously employed on Ubuntu18, which was deprecated.

I chose SUSE because I believe we will be supporting it for however long Derecho is running it. We supported CentOS7 for ~9 years, which is longer than Ubuntu22's lifetime.

Fixes #3403.

@shaomeng
Copy link
Collaborator

I guess the only way to test it out is to merge it and then see how CircleCI handles it, right?

Copy link
Collaborator

@shaomeng shaomeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looking good, thanks Scott!

@sgpearse sgpearse merged commit 00a10a0 into main Nov 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build_ubuntu18_installer tests need to be migrated to ubuntu20
2 participants