Dummy-allocate inactive local variables #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grantfirl
requested review from
climbfuji,
gold2718 and
mkavulich
as code owners
dustinswales
approved these changes
Feb 27, 2024
climbfuji
reviewed
Feb 27, 2024
This was referenced Feb 27, 2024
Merged
gold2718
approved these changes
Feb 29, 2024
|
@dustinswales @grantfirl tests are done at ufs-community/ufs-weather-model#2158. Can you merge this pr? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allocate dummy inactive local variables to size 0.
This is a temporary fix for the RRFS branch that is needed to compile with -check all. Using this flag,
even if variables are not used within a scheme, they are checked for their allocation status, and
unallocated variables lead to a runtime error. This fix goes with the other temporary fixes in
ccpp-physics, fv3atm, etc. for the RRFS branch only. This issue is address more completely via
#529, and will be pulled into main when ready.
User interface changes?: No
Fixes: temporarily addresses ufs-community/ufs-weather-model#2023
Testing:
test removed:
unit tests:
system tests: See ufs-community/ufs-weather-model#2158 for testing results.
manual testing: