Ccpp compliancy after merge step1 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rguments in argument tables, missing 'end subroutine XYZ' statements, case-sensitivity of subroutine names
mzhangw
reviewed
Dec 27, 2017
|
@mzhangw that's right, some of them are internal routines, but I think it is good manner and coding style, and since I was already working on the routines in that file ... |
|
I will not hurt to make the internal routines CCPP compliant, but let's
focus the energy on fixing the "standard names" and any other issues needed
to start testing with the SDF. Can't wait to see how that will turn out!
…On Wed, Dec 27, 2017 at 10:52 AM, Dom Heinzeller ***@***.***> wrote:
@mzhangw <https://github.com/mzhangw> that's right, some of them are
internal routines, but I think it is good manner and coding style, and
since I was already working on the routines in that file ...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#34 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AT9oAnRVDSL_TlcFedf924eRPnFr5qQ5ks5tEoPYgaJpZM4RNrhF>
.
|
mzhangw
reviewed
Dec 27, 2017
climbfuji
pushed a commit
to climbfuji/ccpp-physics
that referenced
this pull request
Jun 17, 2020
Option to roll back Thompson MP to WRFv3.8.1 (RAPv5/HRRRv4), add stochastic perturbations code
hannahcbarnes
pushed a commit
to hannahcbarnes/ccpp-physics
that referenced
this pull request
Aug 3, 2022
dustinswales
pushed a commit
to dustinswales/ccpp-physics
that referenced
this pull request
Feb 7, 2023
RRTMGP refactoring
dustinswales
pushed a commit
to dustinswales/ccpp-physics
that referenced
this pull request
Feb 8, 2023
RRTMGP refactoring
dustinswales
pushed a commit
that referenced
this pull request
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a first round of issues of the merged, separated physics schemes with regards to CCPP-compliancy: