RRTMGP in CCPP (replacement for #400) #413
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…implemented (in progress).
…draw_samples, Cleaned up aerosol increment, Passing random number to RRTMGP cloud sampling.
…sted SW aerosol band ordering in GFS_rrtmgp_pre.F90.
…ieces from suite-level to scheme level.
…oud_microphysics().
climbfuji
requested review from
grantfirl,
JulieSchramm and
llpcarson
as code owners
This was referenced Mar 19, 2020
Closed
grantfirl
reviewed
Mar 26, 2020
grantfirl
reviewed
Mar 26, 2020
grantfirl
reviewed
Mar 26, 2020
grantfirl
reviewed
Mar 26, 2020
grantfirl
reviewed
Mar 26, 2020
grantfirl
reviewed
Mar 26, 2020
grantfirl
reviewed
Mar 26, 2020
grantfirl
reviewed
Mar 26, 2020
grantfirl
reviewed
Mar 26, 2020
|
Darn it. I was looking at that earlier, then went to 400 to see differences
for updating the SCM purposes. I'll move the comments over... Sigh. Thanks
for catching me.
…On Wed, Mar 25, 2020 at 7:54 PM Dom Heinzeller ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In physics/GFS_rrtmg_pre.F90
<#413 (comment)>:
> @@ -155,6 +155,8 @@ subroutine GFS_rrtmg_pre_run (Model, Grid, Sfcprop, Statein, & ! input
rhly, tvly,qstl, vvel, clw, ciw, prslk1, tem2da, &
cldcov, deltaq, cnvc, cnvw, &
effrl, effri, effrr, effrs
+ real (kind=kind_phys) :: clwmin, clwm, clwt, onemrh, value, tem1, tem2, tem3
+ real (kind=kind_phys), parameter :: xrc3 = 100.
Hang on - you are reviewing the wrong PR - need to look at #413
<#413> instead of #400
<#400> - see the note in the
ufs-weather-model PR!
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#413 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGCO5UCDLMFBBFZSVL4MZH3RJKYT7ANCNFSM4LPSOJAQ>
.
--
*Grant J. Firl*
Project Scientist I
Joint Numerical Testbed
Research Applications Laboratory
National Center for Atmospheric Research
FL3-1016: (303) 497-2872
|
|
Sorry, I am also confused. The correct PR on top of Dustin's PR is #411 - Dustin's PR is 413 (on top of which my changes are made).
… On Mar 25, 2020, at 7:55 PM, grantfirl ***@***.***> wrote:
Darn it. I was looking at that earlier, then went to 400 to see differences
for updating the SCM purposes. I'll move the comments over... Sigh. Thanks
for catching me.
On Wed, Mar 25, 2020 at 7:54 PM Dom Heinzeller ***@***.***>
wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In physics/GFS_rrtmg_pre.F90
> <#413 (comment)>:
>
> > @@ -155,6 +155,8 @@ subroutine GFS_rrtmg_pre_run (Model, Grid, Sfcprop, Statein, & ! input
> rhly, tvly,qstl, vvel, clw, ciw, prslk1, tem2da, &
> cldcov, deltaq, cnvc, cnvw, &
> effrl, effri, effrr, effrs
> + real (kind=kind_phys) :: clwmin, clwm, clwt, onemrh, value, tem1, tem2, tem3
> + real (kind=kind_phys), parameter :: xrc3 = 100.
>
>
> Hang on - you are reviewing the wrong PR - need to look at #413
> <#413> instead of #400
> <#400> - see the note in the
> ufs-weather-model PR!
>
> —
> You are receiving this because your review was requested.
> Reply to this email directly, view it on GitHub
> <#413 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AGCO5UCDLMFBBFZSVL4MZH3RJKYT7ANCNFSM4LPSOJAQ>
> .
>
--
*Grant J. Firl*
Project Scientist I
Joint Numerical Testbed
Research Applications Laboratory
National Center for Atmospheric Research
FL3-1016: (303) 497-2872
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#413 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5C2RKRW534M6BWMWIWSE3RJKY2JANCNFSM4LPSOJAQ>.
|
|
OK, am in 411 now.
On Wed, Mar 25, 2020 at 7:57 PM Dom Heinzeller <notifications@github.com>
wrote:
… Sorry, I am also confused. The correct PR on top of Dustin's PR is
#411 - Dustin's PR is 413 (on
top of which my changes are made).
> On Mar 25, 2020, at 7:55 PM, grantfirl ***@***.***> wrote:
>
>
> Darn it. I was looking at that earlier, then went to 400 to see
differences
> for updating the SCM purposes. I'll move the comments over... Sigh.
Thanks
> for catching me.
>
>
> On Wed, Mar 25, 2020 at 7:54 PM Dom Heinzeller ***@***.***
>
> wrote:
>
> > ***@***.**** commented on this pull request.
> > ------------------------------
> >
> > In physics/GFS_rrtmg_pre.F90
> > <#413 (comment)>:
> >
> > > @@ -155,6 +155,8 @@ subroutine GFS_rrtmg_pre_run (Model, Grid,
Sfcprop, Statein, & ! input
> > rhly, tvly,qstl, vvel, clw, ciw, prslk1, tem2da, &
> > cldcov, deltaq, cnvc, cnvw, &
> > effrl, effri, effrr, effrs
> > + real (kind=kind_phys) :: clwmin, clwm, clwt, onemrh, value, tem1,
tem2, tem3
> > + real (kind=kind_phys), parameter :: xrc3 = 100.
> >
> >
> > Hang on - you are reviewing the wrong PR - need to look at #413
> > <#413> instead of #400
> > <#400> - see the note in the
> > ufs-weather-model PR!
> >
> > —
> > You are receiving this because your review was requested.
> > Reply to this email directly, view it on GitHub
> > <#413 (comment)>,
or
> > unsubscribe
> > <
https://github.com/notifications/unsubscribe-auth/AGCO5UCDLMFBBFZSVL4MZH3RJKYT7ANCNFSM4LPSOJAQ
>
> > .
> >
>
>
> --
> *Grant J. Firl*
> Project Scientist I
> Joint Numerical Testbed
> Research Applications Laboratory
> National Center for Atmospheric Research
> FL3-1016: (303) 497-2872
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub <
#413 (comment)>, or
unsubscribe <
https://github.com/notifications/unsubscribe-auth/AB5C2RKRW534M6BWMWIWSE3RJKY2JANCNFSM4LPSOJAQ
>.
>
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#413 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGCO5UG6JUWRKG52PFD2BXDRJKZBDANCNFSM4LPSOJAQ>
.
--
*Grant J. Firl*
Project Scientist I
Joint Numerical Testbed
Research Applications Laboratory
National Center for Atmospheric Research
FL3-1016: (303) 497-2872
|
Great, can you resolve all comments in this PR once you copied them over, please? |
|
Yep.
On Wed, Mar 25, 2020 at 8:03 PM Dom Heinzeller <notifications@github.com>
wrote:
… OK, am in 411 now. On Wed, Mar 25, 2020 at 7:57 PM Dom Heinzeller
***@***.*** wrote:
… <#m_-5828695018692609051_>
Great, can you resolve all comments in this PR once you copied them over,
please?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#413 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGCO5UBFA27FYMBS7V6INW3RJKZYVANCNFSM4LPSOJAQ>
.
--
*Grant J. Firl*
Project Scientist I
Joint Numerical Testbed
Research Applications Laboratory
National Center for Atmospheric Research
FL3-1016: (303) 497-2872
|
climbfuji
added a commit
that referenced
this pull request
Mar 26, 2020
RRTMGP in CCPP (#413 - based on latest code)
|
This PR has been merged as part of #411, closing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #400. It uses the branch rrtmgp-dev2 instead of rrtmgp-dev2-no-mpi_bcast from @dustinswales.
rrtmgp-dev2 is newer than rrtmgp-dev2-no-mpi_bcast, but one file needs to be updated in this branch to turn off the MPI broadcasting (
rrtmg_lw_gas_optics.F90; similar to what was done inrrtmg_sw_gas_optics.F90). This change will be made as part of #411 .For a detailed description, see the original PR #400 by @dustinswales.