Reduce GNU Compilation Warnings #424
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scrasmussen
requested review from
dustinswales,
grantfirl and
mkavulich
as code owners
|
This PR requires CCPP-Physics PR#1048 |
scrasmussen
changed the title
|
@scrasmussen There has been talk for quite a while related to eliminating the dependence on any of the NCEPlibs for the SCM and CCPP. I think that the idea was to use the code in https://github.com/NOAA-EMC/NCEPLIBS?tab=readme-ov-file, write modern interfaces that don't produce any warnings, and include the code in the CCPP physics repo. There should really only be a couple hundred lines that are needed from the W3EMC and SP libs. |
|
PR #468 is a better fix to the issue that this PR fixes. Closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes warnings from the w3emc library warnings because they don't use generic interfaces
The w3emc module commit is just a wrapper to the normal w3emc w3difdat and w3movdat functions but uses generic interfaces in a single file. This means the type warnings only are produced once when compiling the wrapper module, rather than in every file that calls w3difdat and w3movdat. This wrapper file module can easily be removed in the future if the w3emc library decides to move to generic interfaces.
This PR almost fulfills the GNU compiler part of the requirement "Code must compile without errors or warnings. Errors and warnings may not be suppressed, and the compiler warning level ("-W" options) must be at least the default one." as pointed out in ufs-community/ufs-weather-model#1984 (comment). It also a step towards fulfulling the goal/requirement of no warnings from -Wall, as pointed out in NCAR/ccpp-physics#495.