Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make quick invert rest wavelength calculation the same as in dynamics #134

Open
mgalloy opened this issue Oct 18, 2023 · 4 comments
Open
Assignees
Labels
level 2 Affects level2 products needs testing Draft done, testing needed to complete

Comments

@mgalloy
Copy link
Member

mgalloy commented Oct 18, 2023

The mask for the pixels to use in the rest wavelength calculation are not the same for the dynamics and quick invert files. The quick invert calculation should be changed to be the same as the dynamics calculation.

@mgalloy mgalloy added the level 2 Affects level2 products label Oct 18, 2023
@mgalloy mgalloy added this to the 2.1 L2 reprocess milestone Oct 18, 2023
@mgalloy mgalloy self-assigned this Oct 18, 2023
@mgalloy
Copy link
Member Author

mgalloy commented Oct 18, 2023

The rest wavelength should be computed from the uncorrected velocity correct? For example, it is dop, not corrected_dop, in the following calculation:

east_median_rest_wavelength = median(dop[good_east_dop_ind])

The corrected velocity, corrected_dop, is only used again for the values in the "Doppler Velocit" extension.

I think this was a bug in the quick invert rest wavelength calculation.

@detoma
Copy link
Contributor

detoma commented Oct 18, 2023

We are computing the rest wavelength so we can create a corrected_dop. The rest wavelength should be subtracted from the uncorrected dop.

@mgalloy
Copy link
Member Author

mgalloy commented Oct 18, 2023

I think this is done, will see from test in #135.

@mgalloy mgalloy added the needs testing Draft done, testing needed to complete label Oct 26, 2023
@detoma
Copy link
Contributor

detoma commented Dec 21, 2023

Make sure the old code comp_doppler_correction.pro is not used any longer, or, if used, is updated and include the new rest wavelength determination.

Make sure the rest wavelength is not subtracted from velocities that are equal to zero so we do not create erroneous velocity values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level 2 Affects level2 products needs testing Draft done, testing needed to complete
Projects
None yet
Development

No branches or pull requests

2 participants