Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue423 #424

Merged
merged 2 commits into from Jun 21, 2023
Merged

Issue423 #424

merged 2 commits into from Jun 21, 2023

Conversation

kafitzgerald
Copy link
Contributor

@kafitzgerald kafitzgerald commented Jun 21, 2023

PR Summary

Fix bug in _temp_extrapolate used by interp_hybrid_to_pressure.

Closes #423

PR Checklist

General

  • Make an issue if one doesn't already exist
  • Link the issue this PR resolves by adding closes #XXX to the PR description where XXX is the number of the issue.
  • Add a brief summary of changes to docs/release-notes.rst
  • Add appropriate labels to this PR
  • Make your changes in a forked repository rather than directly in this repo
  • Open this PR as a draft if it is not ready for review
  • Convert this PR from a draft to a full PR before requesting reviewers
  • Request @NCAR/geocat for reviews
  • Passes precommit. To set up on your local, run pre-commit install from the top level of the repository. To manually run pre-commits, use pre-commit run --all-files and re-add any changed files before committing again and pushing.

@kafitzgerald kafitzgerald added bug Something isn't working testing Issue related to testing labels Jun 21, 2023
@kafitzgerald kafitzgerald requested a review from a team June 21, 2023 01:10
@kafitzgerald kafitzgerald self-assigned this Jun 21, 2023
@kafitzgerald kafitzgerald marked this pull request as draft June 21, 2023 01:30
@kafitzgerald kafitzgerald removed the request for review from a team June 21, 2023 01:31
@kafitzgerald
Copy link
Contributor Author

Shoot! I just updated the test data subset on one side. Marking this as a draft until I fix that.

@kafitzgerald
Copy link
Contributor Author

Still failing, but only because of what seems to be a precision issue w/ a different function (only w/ the new test data subset).

@kafitzgerald kafitzgerald marked this pull request as ready for review June 21, 2023 16:23
@kafitzgerald kafitzgerald requested a review from a team June 21, 2023 16:34
@kafitzgerald
Copy link
Contributor Author

Ok, pulled the testing updates (though for what it's worth all relevant tests passed w/ the new test data)- will continue looking into that in a separately. Should be ready for review now.

@kafitzgerald kafitzgerald merged commit 4d809bd into NCAR:main Jun 21, 2023
9 checks passed
@kafitzgerald kafitzgerald deleted the issue423 branch June 21, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working testing Issue related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

interp_hybrid_to_pressure temperature extrapolation does not work between 2000 and 2500 m
2 participants