Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PR template #455

Closed
anissa111 opened this issue Sep 8, 2023 · 1 comment · Fixed by #468
Closed

Update PR template #455

anissa111 opened this issue Sep 8, 2023 · 1 comment · Fixed by #468
Assignees
@cyschneck
Labels
good first issue Issues appropriate for beginners

Comments

@anissa111
Copy link
Member

Updates to the PR template (.github/PULL_REQUEST_TEMPLATE.md):

  • remove item about tagging the entire NCAR/geocat team
  • update link to contributor's guide (depends on Contributor's Guide #450)
  • add a note to squash and merge if appropriate for cleaning up commit history
  • remove link to non-existent "documentation standards" on geocat website
  • Reword the "add summary here" comment at top to indicate a written summary should be added in the section in addition to noting the corresponding issue
@anissa111 anissa111 added the good first issue Issues appropriate for beginners label Sep 8, 2023
@erogluorhan erogluorhan added this to the Developers milestone Sep 8, 2023
@cyschneck cyschneck self-assigned this Sep 8, 2023
@cyschneck
Copy link
Contributor

cyschneck commented Sep 12, 2023 •
edited

Changes to the PR template (.github/PULL_REQUEST_TEMPLATE.md):

  • remove item about tagging the entire NCAR/geocat team
  • update link to contributor's guide (depends on Contributor's Guide #450)
  • add a note to squash and merge if appropriate for cleaning up commit history
  • "remove link to non-existent "documentation standards" on geocat website" -> set to Docstrings description in contributions docstrings
  • Reword the "add summary here" comment at top to indicate a written summary should be added in the section in addition to noting the corresponding issue

@anissa111 anissa111 removed this from the Developer Features milestone Sep 12, 2023
@cyschneck cyschneck mentioned this issue Sep 13, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cyschneck cyschneck

Labels
good first issue Issues appropriate for beginners
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update PR template cyschneck/geocat-comp
3 participants
@cyschneck @erogluorhan @anissa111