Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing Edits #476

Merged
merged 3 commits into from Sep 20, 2023
Merged

Contributing Edits #476

merged 3 commits into from Sep 20, 2023

Conversation

cyschneck
Copy link
Contributor

@cyschneck cyschneck commented Sep 19, 2023

PR Summary

Closes #475

PR Checklist

General

  • Make an issue if one doesn't already exist
  • Link the issue this PR resolves by adding closes #XXX to the PR description where XXX is the number of the issue.
  • Add a brief summary of changes to docs/release-notes.rst in a relevant section for the next unreleased release. Possible sections include: Documentation, New Features, Bug Fixes, Internal Changes, Breaking Changes/Deprecated
  • Add appropriate labels to this PR
  • Make your changes in a forked repository rather than directly in this repo
  • Open this PR as a draft if it is not ready for review
  • Convert this PR from a draft to a full PR before requesting reviewers
  • Passes precommit. To set up on your local, run pre-commit install from the top level of the repository. To manually run pre-commits, use pre-commit run --all-files and re-add any changed files before committing again and pushing.
  • If needed, squash and merge PR commits into a single commit to clean up commit history

@cyschneck cyschneck added bug Something isn't working documentation Improvements or additions to documentation labels Sep 19, 2023
Copy link
Contributor

@kafitzgerald kafitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@cyschneck cyschneck changed the title Upstream git URL Contributing Edits Sep 19, 2023
@cyschneck cyschneck self-assigned this Sep 19, 2023
@cyschneck cyschneck marked this pull request as ready for review September 20, 2023 17:42
Copy link
Contributor

@kafitzgerald kafitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching these!

@anissa111 anissa111 self-requested a review September 20, 2023 20:25
@anissa111 anissa111 merged commit 3c14040 into NCAR:main Sep 20, 2023
9 checks passed
@cyschneck cyschneck deleted the documentation branch September 21, 2023 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contributing Edits
3 participants