New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New NSF NCAR Branding #541
Conversation
readthedocs has already been updated to include the new NSF logo, these changes add NSF the few remaining instances in the text I was fixing some Linux issues on my end so when I committed the changes to release-notes and it appears to have duplicated the original commit for some reason, either way, the changes don't conflict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also update docs/index.rst (line 15) and docs/conf.py
Also, don't forget to include this in docs/release-notes.rst
!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still need to make a change here:
Line 258 in 1f14139
"<em>The National Center for Atmospheric Research is sponsored by the National Science Foundation. Any opinions, findings and conclusions or recommendations expressed in this material do not necessarily reflect the views of the National Science Foundation.</em>", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I did reach out to design yesterday to double check on the logos after a quick conversation w/ Orhan about the same thing on a different repo. Apparently the NSF/GeoCAT logo (https://github.com/NCAR/geocat-comp/blob/main/docs/_static/images/logos/GeoCAT_nsf.svg) we have in the upper left hand corner of the docs (and maybe elsewhere) does need to get replaced. Sorry if I suggested otherwise.
The recommendation from design was to use the new NSF NCAR logo displayed on the Sundog page instead.
Let me know if you'd like me to make that change.
I don't see anything in the branding information about crediting NSF as the docs do in via the nsf.png, so can this one remain the same? |
Yeah, I think the GeoCAT only and NSF only logos should be fine - it's just the GeoCAT_nsf.svg that's problematic (as far as I can tell). |
PR Summary
Closes #540
PR Checklist
General
closes #XXX
to the PR description where XXX is the number of the issue.docs/release-notes.rst
in a relevant section for the next unreleased release. Possible sections include: Documentation, New Features, Bug Fixes, Internal Changes, Breaking Changes/Deprecatedprecommit
. To set up on your local, runpre-commit install
from the top level of the repository. To manually run pre-commits, usepre-commit run --all-files
and re-add any changed files before committing again and pushing.