Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New NSF NCAR Branding #541

Merged
merged 8 commits into from Jan 29, 2024
Merged

New NSF NCAR Branding #541

merged 8 commits into from Jan 29, 2024

Conversation

cyschneck
Copy link
Contributor

@cyschneck cyschneck commented Jan 23, 2024

PR Summary

Closes #540

PR Checklist

General

  • Make an issue if one doesn't already exist
  • Link the issue this PR resolves by adding closes #XXX to the PR description where XXX is the number of the issue.
  • Add a brief summary of changes to docs/release-notes.rst in a relevant section for the next unreleased release. Possible sections include: Documentation, New Features, Bug Fixes, Internal Changes, Breaking Changes/Deprecated
  • Add appropriate labels to this PR
  • Make your changes in a forked repository rather than directly in this repo
  • Open this PR as a draft if it is not ready for review
  • Convert this PR from a draft to a full PR before requesting reviewers
  • Passes precommit. To set up on your local, run pre-commit install from the top level of the repository. To manually run pre-commits, use pre-commit run --all-files and re-add any changed files before committing again and pushing.
  • If needed, squash and merge PR commits into a single commit to clean up commit history

@cyschneck cyschneck added the documentation Improvements or additions to documentation label Jan 23, 2024
@cyschneck cyschneck self-assigned this Jan 23, 2024
@cyschneck
Copy link
Contributor Author

readthedocs has already been updated to include the new NSF logo, these changes add NSF the few remaining instances in the text

I was fixing some Linux issues on my end so when I committed the changes to release-notes and it appears to have duplicated the original commit for some reason, either way, the changes don't conflict

@cyschneck cyschneck marked this pull request as ready for review January 23, 2024 22:21
Copy link
Member

@anissa111 anissa111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update docs/index.rst (line 15) and docs/conf.py

Also, don't forget to include this in docs/release-notes.rst!

CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
Copy link
Contributor

@kafitzgerald kafitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

docs/citation.rst Outdated Show resolved Hide resolved
docs/citation.rst Outdated Show resolved Hide resolved
docs/citation.rst Outdated Show resolved Hide resolved
CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
Copy link
Member

@anissa111 anissa111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to make a change here:

"<em>The National Center for Atmospheric Research is sponsored by the National Science Foundation. Any opinions, findings and conclusions or recommendations expressed in this material do not necessarily reflect the views of the National Science Foundation.</em>",

docs/index.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@kafitzgerald kafitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I did reach out to design yesterday to double check on the logos after a quick conversation w/ Orhan about the same thing on a different repo. Apparently the NSF/GeoCAT logo (https://github.com/NCAR/geocat-comp/blob/main/docs/_static/images/logos/GeoCAT_nsf.svg) we have in the upper left hand corner of the docs (and maybe elsewhere) does need to get replaced. Sorry if I suggested otherwise.

The recommendation from design was to use the new NSF NCAR logo displayed on the Sundog page instead.

Let me know if you'd like me to make that change.

@cyschneck
Copy link
Contributor Author

I don't see anything in the branding information about crediting NSF as the docs do in via the nsf.png, so can this one remain the same?

@kafitzgerald
Copy link
Contributor

I don't see anything in the branding information about crediting NSF as the docs do in via the nsf.png, so can this one remain the same?

Yeah, I think the GeoCAT only and NSF only logos should be fine - it's just the GeoCAT_nsf.svg that's problematic (as far as I can tell).

@cyschneck
Copy link
Contributor Author

Logo appears to be replaced properly

@cyschneck cyschneck merged commit 19ea0e3 into NCAR:main Jan 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update assets to comply with the New NSF Branding Theme
3 participants