Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logos for Light and Dark Mode #545

Merged
merged 2 commits into from Jan 30, 2024
Merged

Logos for Light and Dark Mode #545

merged 2 commits into from Jan 30, 2024

Conversation

cyschneck
Copy link
Contributor

@cyschneck cyschneck commented Jan 30, 2024

PR Summary

Closes #540

PR Checklist

General

  • Make an issue if one doesn't already exist
  • Link the issue this PR resolves by adding closes #XXX to the PR description where XXX is the number of the issue.
  • Add a brief summary of changes to docs/release-notes.rst in a relevant section for the next unreleased release. Possible sections include: Documentation, New Features, Bug Fixes, Internal Changes, Breaking Changes/Deprecated
  • Add appropriate labels to this PR
  • Make your changes in a forked repository rather than directly in this repo
  • Open this PR as a draft if it is not ready for review
  • Convert this PR from a draft to a full PR before requesting reviewers
  • Passes precommit. To set up on your local, run pre-commit install from the top level of the repository. To manually run pre-commits, use pre-commit run --all-files and re-add any changed files before committing again and pushing.
  • If needed, squash and merge PR commits into a single commit to clean up commit history

@cyschneck cyschneck self-assigned this Jan 30, 2024
@cyschneck cyschneck added the documentation Improvements or additions to documentation label Jan 30, 2024
@cyschneck
Copy link
Contributor Author

Logo will alternate between dark/light mode depending on theme, see here

@cyschneck cyschneck marked this pull request as ready for review January 30, 2024 21:32
@anissa111
Copy link
Member

This looks good!

Screen Recording 2024-01-30 at 5 36 50 PM

@cyschneck cyschneck merged commit 5f8baf7 into NCAR:main Jan 30, 2024
12 checks passed
@cyschneck cyschneck deleted the nsf_540 branch February 12, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update assets to comply with the New NSF Branding Theme
3 participants