Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes ASV version pin and pin Conda version for ASV workflow #610

Merged
merged 15 commits into from
May 1, 2024

Conversation

kafitzgerald
Copy link
Contributor

@kafitzgerald kafitzgerald commented Apr 30, 2024

PR Summary

Removes ASV version pin and pin micromamba version for ASV workflow
Closes #555
Closes #607 (though we should log another issue or keep this open until we can unpin conda)

PR Checklist

General

  • Make an issue if one doesn't already exist
  • Link the issue this PR resolves by adding closes #XXX to the PR description where XXX is the number of the issue.
  • Add a brief summary of changes to docs/release-notes.rst in a relevant section for the next unreleased release. Possible sections include: Documentation, New Features, Bug Fixes, Internal Changes, Breaking Changes/Deprecated
  • Add appropriate labels to this PR
  • Make your changes in a forked repository rather than directly in this repo
  • Open this PR as a draft if it is not ready for review
  • Convert this PR from a draft to a full PR before requesting reviewers
  • Passes precommit. To set up on your local, run pre-commit install from the top level of the repository. To manually run pre-commits, use pre-commit run --all-files and re-add any changed files before committing again and pushing.
  • If needed, squash and merge PR commits into a single commit to clean up commit history

@kafitzgerald
Copy link
Contributor Author

This changes from micromamba to miniconda so that we can easily set the conda version to avoid the current ASV failure. It looks like we can do environment caching w/ miniconda now too though it's a bit clunkier I think and I haven't implemented that yet.

It also unpins the ASV version since the new one works and moves that install from pip to conda since that's now an option.

See here for an example workflow run: https://github.com/kafitzgerald/geocat-comp/actions/runs/8898705224/job/24436440204

@kafitzgerald kafitzgerald added dependencies Pull requests that update a dependency file scalability and performance Related to scalability, performance, or benchmarking labels May 1, 2024
@kafitzgerald kafitzgerald marked this pull request as ready for review May 1, 2024 15:39
@kafitzgerald kafitzgerald changed the title Removes ASV version pin and pins micromamba version for ASV workflow Removes ASV version pin and pin Conda version for ASV workflow May 1, 2024
@kafitzgerald kafitzgerald marked this pull request as draft May 1, 2024 15:52
@kafitzgerald
Copy link
Contributor Author

kafitzgerald commented May 1, 2024

Caching packages rather than envs didn't really help to the same degree so I went back and set up env caching. It's a good bit more verbose than with the micromamba action, but it gets the job done for now and we can switch back later if desired.

Should be good to go now hopefully.

@kafitzgerald kafitzgerald marked this pull request as ready for review May 1, 2024 16:20
@kafitzgerald kafitzgerald requested review from anissa111 and removed request for anissa111 May 1, 2024 17:28
Copy link
Member

@anissa111 anissa111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks for fixing this!

@kafitzgerald kafitzgerald merged commit 2a90fad into NCAR:main May 1, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file scalability and performance Related to scalability, performance, or benchmarking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI Failure: ASV ASV Failures - April 24, 2024
2 participants