Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.12 support and Windows and M1 testing #194

Merged
merged 1 commit into from Feb 2, 2024

Conversation

kafitzgerald
Copy link
Contributor

@kafitzgerald kafitzgerald commented Feb 1, 2024

PR Summary

Adds Python 3.12 support and Windows and M1 to test matrix.

For what it's worth, it looks like the M1 runners are slated to become macos-latest sometime in late spring / summer of 2024.

Closes #167 and #193

PR Checklist

General

  • Make an issue if one doesn't already exist
  • Link the issue this PR resolves by adding closes #XXX to the PR description where XXX is the number of the issue.
  • Add a brief summary of changes to docs/release-notes.rst in a relevant section for the next unreleased release. Possible sections include: Documentation, New Features, Bug Fixes, Internal Changes, Breaking Changes/Deprecated
  • Add appropriate labels to this PR
  • Make your changes in a forked repository rather than directly in this repo
  • Open this PR as a draft if it is not ready for review
  • Convert this PR from a draft to a full PR before requesting reviewers
  • Passes precommit. To set up on your local, run pre-commit install from the top level of the repository. To manually run pre-commits, use pre-commit run --all-files and re-add any changed files before committing again and pushing.

@kafitzgerald kafitzgerald added developer feature For development standardization / best practices / enhancement enhancement New feature or request labels Feb 1, 2024
@kafitzgerald kafitzgerald marked this pull request as ready for review February 1, 2024 20:57
Copy link
Collaborator

@jukent jukent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes love it

@kafitzgerald kafitzgerald merged commit 1f0afc3 into NCAR:main Feb 2, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer feature For development standardization / best practices / enhancement enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Python 3.12
2 participants