Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dtc/hwrf-physics: update from HAFS community #48

Merged
merged 16 commits into from
May 20, 2020
Merged

dtc/hwrf-physics: update from HAFS community #48

merged 16 commits into from
May 20, 2020

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented May 14, 2020 •
edited
Loading

This PR:

Associated PRs:
NCAR/ccpp-physics#453
NCAR/fv3atm#50
#48

For regression testing information, see below.

TomBlack-NOAA and others added 10 commits April 9, 2020 10:42
@TomBlack-NOAA
Regional BC blending and BCs into GSI (ufs-community#83)
7097078
@AnningCheng-NOAA
Options for IN/CNN and MERRA2 climo of microphysics (ufs-community#90)
7c3cdca 
Add two options for IN/CCN activation and have total three options now:
* iccn=0 for temperature dependence, iccn=1 for climatological IN/CCN, and iccn=2 for MERRA2aersol
* add the option to enable RRTMg aerosol attenuation to be determined from prescribed MERRA2 climatology
* add aerosol optical depth outputs for total, dust, black carbon, organic carbon, sulfate, and sea salt

Add 4 regression tests:
 1) SAS+GFDL with enabled RRTMg aerosol attenuation from prescribed MERRA2 climatology (fv3_gocart_clm in rt.conf_csaw),
 2) CSAW+MG3 with with enabledRRTMg aerosol attenuation from prescribed MERRA2 climatology (fv3_gfsv16_csawmg  in rt.conf_csaw),
 3) CSAW+MG3 with enabled RRTMg aerosol attenuation from OPAC (fv3_gfsv16_csawmgt in rt.conf_csaw), and
 4) CSAW+MG3 with climatological IN/CCN with enabled RRTMg aerosol attenuation from prescribed MERRA2climatology (fv3_csawmg)
@climbfuji @aerorahul
Merge NCAR:dtc/develop into develop 2020/04/14 (ufs-community#102)
3b16cad 
* add s4 rules

* update submodule pointers

* update the branch in gitmodules to point to NEMS::feature/s4

* Update .gitmodules and submodule pointer for ccpp-physics for code review and testing

* Merge NCAR:dtc/develop into ufs-community:develop

- for macOS with LLVM clang, turn off OpenMP (from UFS public release)
- switch to Intel 18 on wcoss_cray
- new regression tests with RRTMGP using current control as basis

Co-authored-by: Rahul Mahajan <rmahajan@s4-submit.ssec.wisc.edu>
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
@DusanJovic-NOAA
Port to Orion (ufs-community#105)
8baa79d
@climbfuji
Remove dynamic CCPP build (ufs-community#107)
ce9fefb 
* Remove CCPP dynamic build from ufs-weather-model
* Remove LD_LIBRARY_PATH entries in regression test setup scripts
@junwang-noaa @JongilHan66
@jswhit2 @DomHeinzeller @climbfuji @DeniseWorthen
Chsp latlon post (ufs-community#108)
d202a02 
* update post lib to 8.0.6
* Add chsp to gfsphysics and ccpp-physics
add global_latlon grid on write grid comp for netcdf output
add landsfcmdl attribute to fv3 sfc history file
update post to post/8.0.6
* Bugfix for Intel 18 on wcoss_cray, remove Intel 16 options for gaea
* add global latlon grid test
* Add regression tests for lheatstrg to IPD REPRO, CCPP REPRO, CCPP PROD; add regression tests for satmedmfvidfq for IPD PROD, IPD REPRO, CCPP REPRO, CCPP PROD; add ecflow config for cheyenne
* add cmeps integration changes

Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com>
Co-authored-by: Jongil Han <Jongil.Han@noaa.gov>
Co-authored-by: Jeffrey Whitaker <Jeffrey.S.Whitaker@noaa.gov>
Co-authored-by: Dom Heinzeller <dom.heinzeller@noaa.gov>
Co-authored-by: Dom Heinzeller <climbfuji@ymail.com>
Co-authored-by: Denise Worthen <Denise.Worthen@noaa.gov>
Co-authored-by: Jun Wang <junwang@Orion-login-3.HPC.MsState.Edu>
@BinLiu-NOAA
Merge branch 'develop' into support/HAFS
381ca35
@BinLiu-NOAA
Load a newer version cmake on Jet.
11849eb
@BinLiu-NOAA
Link modulefiles/orion.intel into modulefiles/orion to supoort HAFS w…
c3a13c0 
…orkflow.
@climbfuji
Update .gitmodules and submodule pointer for fv3atm for code review a…
8be42ad 
…nd testing
This was referenced May 14, 2020
Merged
Merged
@climbfuji climbfuji force-pushed the update_dtc_hwrf_physics_from_hafs_community branch from 0c986cd to d067fc6 Compare May 14, 2020 22:49
@climbfuji climbfuji marked this pull request as ready for review May 15, 2020 20:59
mzhangw
mzhangw approved these changes May 15, 2020
View reviewed changes
Copy link
Collaborator

@mzhangw mzhangw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@climbfuji
Copy link
Collaborator Author

Regression testing on hera.intel using rt.conf against existing EMC baseline. The following tests fail as expected (see previous PRs for explanations):

(PROD)
fv3_stretched_nest
fv3_stretched_nest_quilt
fv3_regional_c768
(REPRO)
fv3_ccpp_gfdlmp_hwrfsas
fv3_ccpp_regional_c768_FA
fv3_ccpp_regional_c768_HWRF_PBL
fv3_ccpp_regional_c768_FA_HWRF_RRTMG
(PROD)
fv3_ccpp_stretched_nest
fv3_ccpp_gfdlmp_hwrfsas
fv3_ccpp_regional_c768
fv3_ccpp_regional_c768_HWRF_PBL
fv3_ccpp_regional_c768_FA
fv3_ccpp_regional_c768_FA_HWRF_RRTMG

rt_hera_intel_against_emc_develop_20200424.log
rt_hera_intel_against_emc_develop_20200424_fail_test.log

@ligiabernardet
Copy link
Collaborator

Thanks for updating this branch and enable running on Orion. Looks good to me.

@climbfuji
Copy link
Collaborator Author

climbfuji commented May 18, 2020 •
edited
Loading

Regression testing on cheyenne.intel using rt_intel.conf: first create new baseline, then copy to final location, then verify. The following tests fail (known issue):

(REPRO)
fv3_ccpp_regional_c768_FA
fv3_ccpp_regional_c768_HWRF_PBL
fv3_ccpp_regional_c768_FA_HWRF_RRTMG
(PROD)
fv3_ccpp_regional_c768_FA
fv3_ccpp_regional_c768_HWRF_PBL
fv3_ccpp_regional_c768_FA_HWRF_RRTMG

rt_cheyenne_intel_create.log
rt_cheyenne_intel_create_step2.log
rt_cheyenne_intel_verify.log

UPDATE 05/20/2020: redoing the baseline creation and testing against it after copying the latest regression test input data from hera. Results are the same as above.

rt_cheyenne_intel_create.log
rt_cheyenne_intel_verify.log

@climbfuji
Copy link
Collaborator Author

Update @mzhangw @ligiabernardet : there is a weird issue with the GNU tests on Cheyenne, they no longer pass the IPD-CCPP b4b comparison in REPRO mode. I don't know why, this version of the code should still pass. I may just turn the IPD tests and the CCPP repro tests off entirely, as long as the CCPP tests reproduce against the previous HWRF physics baseline and the original EMC baseline. Not today anymore, though.

@climbfuji
Copy link
Collaborator Author

Regression testing on cheyenne.gnu rt_gnu.conf: first create new baseline, then copy to final location, then verify. After removing the IPD tests and the CCPP REPRO tests, i.e. the IPD-CCPP comparison, all tests pass.

rt_cheyenne_gnu_create.log
rt_cheyenne_gnu_verify.log

@climbfuji
Copy link
Collaborator Author

@ligiabernardet @mzhangw these PRs are finally ready to merge. Will start in a bit.

@ligiabernardet
Copy link
Collaborator

ligiabernardet commented May 20, 2020 via email

@climbfuji climbfuji merged commit 1fe881c into NCAR:dtc/hwrf-physics May 20, 2020
SamuelTrahanNOAA added a commit to SamuelTrahanNOAA/ufs-weather-model that referenced this pull request Dec 17, 2020
@SamuelTrahanNOAA
Merge pull request NCAR#48 from SamuelTrahanNOAA/feature/v2-ca-pert-g…
58675b0 
…bbepx

SPPT and CA perturbations of SO2 emissions + 2 regtests
mzhangw pushed a commit to mzhangw/ufs-weather-model that referenced this pull request Jul 30, 2021
@DusanJovic-NOAA
GFSv16 netcdf post ficein cpl (NCAR#36)
52795b8 
* Updated fv3atm (see fv3atm PR NCAR#48 NOAA-EMC/fv3atm#48)
* Updated WW3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzhangw mzhangw mzhangw approved these changes

@grantfirl grantfirl Awaiting requested review from grantfirl grantfirl is a code owner

@llpcarson llpcarson Awaiting requested review from llpcarson

@ligiabernardet ligiabernardet Awaiting requested review from ligiabernardet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@climbfuji @ligiabernardet @mzhangw @TomBlack-NOAA @AnningCheng-NOAA @DusanJovic-NOAA @junwang-noaa @BinLiu-NOAA