-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Automatic PyPI Integration #176
Conversation
In general, yes, it'd be great to have consistency. However, how and when to implement that is up to you: Either do all of them in this PR, or re-title this PR to something like "Changes for publishing WRF-Python to PyPI" and only do this, then do others in a separate PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pypi.yaml file looks good, but, in order to get the PyPI publishing work well with all its components (e.g. project description. LICENSE file etc.), you may want to see the conversation and changed files from this recent GeoCAT-datafiles PR or the first GeoCAT-comp PR that introduced PyPI publishing.
I believe I have updated this PR to better reflect what is used in other GeoCAT repos. I left the "Author" kwarg in setup.py as "Bill Ladwig" as I believe he did author this software solely, but removed his contact info in place of GeoCAT and listed GeoCAT as the maintainers (along with some other changes to better emulate the rest of GeoCAT). Let me know if there is anything else that may be missing or needing updating, but comparing to the datafiles and comp PRs I believe we should have everything necessary in the repo already |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure about a few things:
- LICENSE FILE file has the correct format
- requirements.txt lists all the requirements
- Why build tests fail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
Adds configuration to automatically update PyPI when new versions are released
Do we want to add any other items to the workflow (pre-commit, code-cov, etc) to look more like the other GeoCAT repos, or are we fine leaving wrf-python with PyPI and CI only?