Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NUOPC cap and add NUOPC CMake build #546

Merged
merged 1 commit into from
Apr 22, 2021

Conversation

danrosen25
Copy link
Collaborator

TYPE: new feature

KEYWORDS: NUOPC, CMake, UFS, RRFS

SOURCE: Daniel Rosen (drosen@ucar.edu) - NCAR/ESMF

DESCRIPTION OF CHANGES: New feature for building wrfhydro_nuopc library. Also fixes issue related to orchestrator init in the NUOPC gluecode.

  1. add WRF_HYDRO_NUOPC build option to CMake
  2. build wrfhydro_nuopc library if WRF_HYDRO_NUOPC=1
  3. fix NUOPC gluecode init

ISSUE: none

TESTS CONDUCTED:
UFS SR Weather App https://github.com/NESII/ufs-srweather-app

  • Built ufs_model on cheyenne ./devbuild.sh cheyenne --components=WRFHYDRO
  • Built ufs_model on jet ./devbuild.sh jet --components=WRFHYDRO
  • Ran ufs_model with preconfigured NWM LR use case and FORC_TYP = 8 (LDASOUT) on jet

NOTES: ufs_model uses NUOPC cap. The WRFHYDRO NUOPC cap bypasses HRLDAS and therefore must be coupled to a LSM or use FORC_TYP = 8

Checklist

  • Closes issue #xxxx
  • Tests added (unit tests and/or regression/integration tests)
  • Backwards compatible
  • Requires new files? If so, how to generate them.
  • Fully documented
  • Short description in the Development section of NEWS.md

1. add WRF_HYDRO_NUOPC build option to CMake
2. build wrfhydro_nuopc library
3. fix NUOPC gluecode init
@donaldwj
Copy link
Collaborator

This pull request is for the old NUOPC cap not the new one created by the Coastal-Act Project correct?

@danrosen25
Copy link
Collaborator Author

@donaldwj
That's right. I haven't seen the Coastal-Act Project's cap and it must be stored elsewhere. Eventually we'd want to merge all caps together.

@rcabell rcabell merged commit ba02e46 into NCAR:v5.2.x Apr 22, 2021
rcabell pushed a commit that referenced this pull request Apr 22, 2021
1. add WRF_HYDRO_NUOPC build option to CMake
2. build wrfhydro_nuopc library
3. fix NUOPC gluecode init
@danrosen25 danrosen25 deleted the feature/NUOPC_CMake branch May 12, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants