Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit fix for soil column bottom runoff for CHRTOUT/Channel-only fluxes #76

Closed
wants to merge 1 commit into from
Closed

Unit fix for soil column bottom runoff for CHRTOUT/Channel-only fluxes #76

wants to merge 1 commit into from

Conversation

jmccreight
Copy link
Collaborator

I think one of these was not fixed. @logankarsten to verify.

@wrf-hydro-nwm-bot
Copy link
Collaborator

Waiting for private pull request queue to clear.

@dblodgett-usgs dblodgett-usgs mentioned this pull request Jun 28, 2018
Closed
logankarsten
logankarsten approved these changes Jun 28, 2018
View reviewed changes
Copy link
Contributor

@logankarsten logankarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. If it's a runoff term, then it indeed should be "m3 s-1". Probably slipped through the cracks as I don't believe this is a NWM output.

@kafitzgerald
Copy link
Contributor

I'm going to close this and log a more complete issue.

The good news:
The units are correct (though arguably confusing) for NWM configurations (qBtmVertRunoff is qin_gwsubbas in the code and units are m^3 accumulated over the timestep).

The bad news:
For non-NWM (UDMAP=0) configurations the simp_gw_buck subroutine has qin_gwsubbas in units of m^3/s.

@jmccreight jmccreight deleted the unit_fix branch September 28, 2018 17:45
jmccreight pushed a commit to jmccreight/wrf_hydro_nwm_public that referenced this pull request Nov 13, 2018
Merge pull request NCAR#76 from jmills-ncar/master
8502aeb 
refactoring file path handling
laurareads pushed a commit to laurareads/wrf_hydro_nwm_public that referenced this pull request Apr 3, 2019
Merge pull request NCAR#76 from mollymca/master
344c97a 
Text changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logankarsten logankarsten logankarsten approved these changes

@aubreyd aubreyd Awaiting requested review from aubreyd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jmccreight @wrf-hydro-nwm-bot @kafitzgerald @logankarsten