Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-black string format conversion #47

Conversation

sadielbartholomew
Copy link
Member

Close #46, at least for the vast majority of cases, particularly those involving much longer lines, with mixed and/or non f-string formatted strings

Note there are lots of new-line characters peppered about the strings especially for user messages, which I will remove (they are not useful since users will be viewing these on terminals or IDEs or similar of variable width where standard line wrapping will apply for readability, and these custom new lines could cause weird gaps and wrapping issues) but I will do that as a separate issue since it is distinct and a significant task in its own right. I have generally only removed/added new line characters to preserve the behaviour of the string with any change of formatting.

I will do a self-review before merging since there is so little testing at present (one of the next priorities it to get some and increase coverage!) so I won't be convinced I haven't inadvertently broken something during the conversion until I've checked the pushed line changes carefully.

@sadielbartholomew
Copy link
Member Author

One commit added with some fixes noticed in self-review. I am satisfied this is all good after that, so merging.

@sadielbartholomew sadielbartholomew merged commit efe94c7 into NCAS-CMS:master Apr 8, 2024
@sadielbartholomew sadielbartholomew deleted the post-black-string-formatting branch April 8, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistent string formatting, esp. update long string creation via +=
1 participant