-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP8 compliance: review (& justify chosen) exclusions #64
Comments
I think that I'm happy with all of these exclusions, apart from
We should, at the very least, turn these into |
Ah, good idea! I would have done that when finalising the PEP8 amendments but I assumed that On the topic, I have noticed that cfdm and cf-python do not use any custom exceptions, with the exception (hah) of a pair of |
Hi Sadie - good. I have made those changes and will push them shortly. Custom exceptions are absolutely fine (there's no particular reason why we don't have many). Let's close this issue and pick up making custom exceptions in a new thread. |
Good plan.
FYI I quickly added in PEP8 checks on some Python files outside of the |
For
cfdm
as for cf-python defined in an equivalent issue NCAS-CMS/cf-python#83; thecfdm
codebase is now PEP8-compliant under the interpretation & scope of thepycodestyle
library, with the exception of several rules I have explicitly excluded (where there is no easy way to exclude instead on a per-case/line basis, sadly). We should review these exclusions, in this case being:cfdm/cfdm/test/test_style.py
Lines 22 to 31 in 7319bf8
& decide whether
pycodestyle
is the right tool, among many options, for our requirements on linting.The text was updated successfully, but these errors were encountered: