Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failures could occur when reading and writing datasets with multiple geometry containers #65

Closed
davidhassell opened this issue Jul 28, 2020 · 2 comments · Fixed by #67
Closed

Failures could occur when reading and writing datasets with multiple geometry containers #65

davidhassell opened this issue Jul 28, 2020 · 2 comments · Fixed by #67
Assignees
@davidhassell
Labels
bug Something isn't working netCDF read Relating to reading netCDF datasets netCDF write Relating to writing netCDF datasets

Comments

@davidhassell
Copy link
Contributor

This is related to the way in which geometry containers are parsed (in netcdfread.py and netcdfwrite.py), and is being investigated ....
@davidhassell davidhassell added the bug Something isn't working label Jul 28, 2020
@davidhassell davidhassell self-assigned this Jul 28, 2020
@davidhassell davidhassell mentioned this issue Jul 29, 2020
Merged
davidhassell added a commit that referenced this issue Jul 29, 2020
@davidhassell
Merge pull request #66 from davidhassell/duplicate_netCDF_dimensions
d12a7ef 
Partially addresses #65
@davidhassell
Copy link
Contributor Author

PR #66 partially addresses this.

It is a tough problem, as it involves considering whether or not independent Field constructs that have goemetry containers should share a netCDF dimension for their data. In particular, when they have different geometry containers that share node coordinates.

@davidhassell
Copy link
Contributor Author

The outstanding issue was related to the erroneous sharing of node coordinates when the corresponding node_count variables needed to span different dimensions (to match the parent data variable). Now fixed.

@davidhassell davidhassell mentioned this issue Aug 4, 2020
Merged
davidhassell added a commit that referenced this issue Oct 5, 2020
@davidhassell
issue #65
7b57fa6
@davidhassell davidhassell added netCDF write Relating to writing netCDF datasets netCDF read Relating to reading netCDF datasets labels Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidhassell davidhassell

Labels
bug Something isn't working netCDF read Relating to reading netCDF datasets netCDF write Relating to writing netCDF datasets
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Multiple geometries write/read fixes davidhassell/cfdm
1 participant
@davidhassell