Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wonky name-matching policies in autocomplete #312

Closed
remontoire-pac opened this issue Jun 6, 2023 · 8 comments
Closed

wonky name-matching policies in autocomplete #312

remontoire-pac opened this issue Jun 6, 2023 · 8 comments
Labels
autocomplete UI - term selection identification of the specific node and context to be selected for a query

Comments

@remontoire-pac
Copy link

and not reproducible

@sierra-moxon
Copy link
Member

following up with @remontoire-pac - this is another instance of:
"autocomplete results change on each addition of a new letter, but suggestions, after the new letter is added, are a completely different set of results."

@remontoire-pac
Copy link
Author

important new nuances:

  • the "new letter" added might even be a space
  • deleting the new letter does not bring back the original results

@sierra-moxon sierra-moxon added UI - term selection identification of the specific node and context to be selected for a query autocomplete labels Jun 7, 2023
@dnsmith124
Copy link
Collaborator

It sounds like the issue here is twofold:

  1. The suggestions returned by the autocomplete are significantly different when a search term changes by only a single letter
  2. Suggestions are not consistent when the same input string is searched more than once.

Is that correct? If so I think the former problem should be resolved by the biolink type selection feature planned for the name resolver. The latter sounds like a problem not with the UI but with the Name Resolver or Node Normalizer not consistently returning the same terms for a given input string.

@remontoire-pac
Copy link
Author

remontoire-pac commented Jun 11, 2023 via email

@gaurav
Copy link

gaurav commented Jun 22, 2023

Tracking at TranslatorSRI/NameResolution#64

@gaurav
Copy link

gaurav commented Jul 21, 2023

This should be fixed once UI switches over to the new NameRes (with the possible exception for genes, but we're trying to fix that now). I'll close once we can confirm that this is the case. We now have some testing tools available to make sure this works correctly in NameRes.

@gaurav
Copy link

gaurav commented Jul 28, 2023

@remontoire-pac could you please retest this at https://ui.ci.transltr.io/? It should be fixed now.

@remontoire-pac
Copy link
Author

remontoire-pac commented Aug 10, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocomplete UI - term selection identification of the specific node and context to be selected for a query
Projects
None yet
Development

No branches or pull requests

4 participants