-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imProving Agent returning results with drug names like "Pubchem.compound:6710690" instead of "Pharmakon1600-01504273" with lots of examples like this. I.e. CURIEs being returned, not names #568
Comments
A better example: "Pubchem.compound:151537" instead of "4'-Epidoxorubicin (hydrochloride)". |
I queried the compound The second issue here is NodeNorm choosing not the optimal label. This is a known issue. |
@gprice1129 can you speak to whether the backend is doing this with the names? The UI's frontend simply displays the names provided, and in the results I'm seeing from the example the 'Pubchem' terms are being given as the names for these results. |
@sandrine-muller-research where does your preferred name come from? |
@dnsmith124 @sandrine-m @MarkDWilliams the backend just takes the names we are given by the ARS. The ARS should be converting these names from CURIEs to whatever name is decided as the "best" one by NodeNorm. |
@Genomewide from NodeNorm PROD endpoint : |
this still happens, i dont know if there is a solution @gaurav https://ui.test.transltr.io/main/results?l=VPS13B%20(Human)&i=NCBIGene:157680&t=1&r=0&q=d9bc14f5-c11a-4625-aef7-1ed76c3f7179 |
Here's how we're doing on NodeNorm CI:
I'm tracking non-good preferred names in this spreadsheet as well as TranslatorSRI/Babel#306, but that work won't help these two cliques, because none of the other identifiers have a good label for this identifier. So we will probably need to pull in additional sources of labels and identifiers to fully fix this. I'm going to come back to this in Hammerhead, but unless there's a good source we're missing this will likely go unfixed this year. (There's another ticket where we're discussing other solutions, such as having the UI display the CURIE -- "PUBCHEM.COMPOUND:151537" instead of "(7S,9S)-..." -- see #759) |
Type: Bug Report
URL: https://ui.transltr.io/main/results?l=VPS13B%20(Human)&i=NCBIGene:157680&t=1&q=9c390038-73fc-4d7d-8c63-c08d85eda8b0
ARS PK: 9c390038-73fc-4d7d-8c63-c08d85eda8b0
Steps to reproduce:
Search for drugs that upregulate VPS13B
Screenshots:
The text was updated successfully, but these errors were encountered: