Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move which_in_eml to ropensci/EML #149

Open
dmullen17 opened this issue Jul 6, 2018 · 1 comment
Open

Move which_in_eml to ropensci/EML #149

dmullen17 opened this issue Jul 6, 2018 · 1 comment

Comments

@dmullen17
Copy link
Member

@maier-m I'm cleaning up datamgmt and this function makes way more sense in EML. Did you ever ask if Karl wanted to add it to the ropensci/EML package?

If you're interested in the longer story: I used which_in_eml as a helper in this function NCEAS/arcticdatautils#97, but because datamgmt already imports arcticdatautils then arcticdatautils cannot import any datamgmt functions because this creates a cyclic package dependency. My hacky solution was to add which_in_eml to arcticdatautils so I could use it 🙄, but it makes way more sense in EML.

@maier-m
Copy link
Contributor

maier-m commented Jul 6, 2018

Yeah, you could try to move it to EML... I think most the devel is being done on eml2 though and may be better to port there with some small code mods. Not entirely sure though, I never asked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants