Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datamgmt::create_attributes_table goes buggy after entering ~10 attributes #192

Open
jagoldstein opened this issue Jun 3, 2019 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@jagoldstein
Copy link

jagoldstein commented Jun 3, 2019

The Shiny UI opened from datamgmt::create_attributes_table() stops letting users populate/edit cells after ~10 attributes are entered.

@jagoldstein jagoldstein added the bug Something isn't working label Jun 3, 2019
@dmullen17
Copy link
Member

It works for me if right-click and click either "Insert row above" or "Insert row below"

@jagoldstein
Copy link
Author

that works for a few attributes for me and the interns, but then breaks before the 20th attribute. @dmullen17 how many rows did you try adding and filling in?

@dmullen17
Copy link
Member

I just did 34, could've kept going but I think the function is fine. To scroll down you need to move your cursor all the way over to scroll bar on the right - it won't automatically scroll down to the next row when it's created.

@jagoldstein
Copy link
Author

No, the issue does not have to do with scrolling. More rows can be added. The bug has to do with not being able to populate the cells. I'll show you in-person.

@dmullen17
Copy link
Member

Ah I see. I was able to populate attribute names up to those 34 rows, but when I tried to add domain it bugged out

@dmullen17
Copy link
Member

dmullen17 commented Jun 3, 2019

I'm able to edit rows past the 10th row as long as I pre-populate them with some dummy data before I run the shiny app.

x <- data.frame(matrix(NA, 1, 45))
shiny_attributes(x)

So now i'm curious as to whether this ever worked. It's possible that we've always had some sort of PI-generated metadata, whether it's a csv or an EML attributes table, that we pass as an input to create_attributes_table, thereby not triggering this bug. That would make this the first attributes table with > 10 attributes that we've generated 100% by hand.

@jagoldstein
Copy link
Author

That's interesting. Let's meet with Noelle this afternoon to inquire, but on Friday she claimed that she's been using this same workflow for a while (opening blank tables and adding attributes manually for NetCDF files with ~46 attributes). She said that it worked fine as recently as the morning of May 29, 2019 (last week). So that would mean it broke sometime between then and 2pm PDT May 31, 2019.

@dmullen17
Copy link
Member

I think it's worth leaving this open as a bug, but given that I've found a viable workaround (just populate the table with as many dummy rows as you need), it's going to be pretty low on my priorities right now. I read through the underlying code and read through some related stackoverflow issues but didn't find anything thus far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants