Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-hack Metacat use of Port Numbers to Determine https vs http #1697

Closed
artntek opened this issue Sep 20, 2023 · 3 comments
Closed

Un-hack Metacat use of Port Numbers to Determine https vs http #1697

artntek opened this issue Sep 20, 2023 · 3 comments
Assignees
Milestone

Comments

@artntek
Copy link
Contributor

artntek commented Sep 20, 2023

Metacat currently serves traffic via https only if the server.httpPort AND the server.httpSSLPort are BOTH set to 443. This is confusing and error-prone, and means we can't directly tell if metacat urls should be http or https for other applications (e.g. see #1700).

Fixing it will also allow us to automatically configure the base metacat url used by the dataone_indexer, since that currently assumes https, and therefore breaks on non-SSL deployments.

When Jing and I were discussing this, we decided an approach like this could work:

server.name=localhost
server.httpPort=8443
server.isSSL=true
@taojing2002
Copy link
Contributor

taojing2002 commented Nov 18, 2023

@artntek What are about those names?

server.name=localhost
server.port=8443
server.https=true

The labels are:

Server Name:
Server Port:
Server Https:  True/False

httpPort implies http, not https. port seems neutral.
ssl may be too technical.

@taojing2002
Copy link
Contributor

@artntek I updated the above comment.

@artntek
Copy link
Contributor Author

artntek commented Nov 18, 2023

Works for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants