Improve ISO view for generic ISO, NCEI, and Pangaea content #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While fixing #1232 I couldn't help but notice some issues with this XSL. - XPaths were hardcoded for things like /gmd:identificationInfo/gmd:MD_DataIdentification but MD_DataIdentification is also largely swappable for SV_ServiceIdentification too so I've relaxed the XPath to catch both - I was using both // and .// so I switched everything to .// to be consistent. Not sure what's best practice - Found a bug in the Metadata Contacts and cited responsible parties sections which were assuming that section was always present in the metadata even though it's optional -I simplified the XPath for dataset contact - I added some comments to annotate the code a bit more for consistency
It turns out dataset contact, as defined by gmd:pointOfContact is optional and the xslt wasn't accounting for this
I failed to merge these changes I'm collpasing the two branches
|
Hey @taojing2002 this is code we would like in the next release but we'd also like this to get released with @laurenwalker 's MetacatUI 1.14.15 patch release. We moved the Alternate Data Access Table from MetacatUI and put it in Metacat's View Service so if these two products aren't released/patched at the same time the user will see two tables. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains various bug fixes some major improvements to the ISO View Service XLTs. These changes will impact any ISO19139 content and how it renders out of the View Service.
Summary:
contentInfoelements in itdistributionInfo) by putting a table of links at the top of the view@taojing2002 would you mind taking a look-through? I've hot-patched
cn-stage-ucsb-1with these changes and done some moderate testing but always appreciate feedbacl. See https://search-stage.test.dataone.org/#view/doi:10.1594/PANGAEA.832895_20170724_1121 for an example.