Feature 1623 - helm: separating administrator.username & auth.administrators properties
#1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ministrators proeprty, so we can still provide a list of admins
artntek
changed the title
administrator.username & auth.administrators properties
taojing2002
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to Issue #1623
I originally conflated the admin username (used for DB upgrades at launch) with the
auth.administratorsproperty, when cleaning up the dockerfile and entrypoint script (i.e. I cleaned it up just a little too much :-) This meant that we could no longer provide a colon-delimited list of allowed admins forauth.administrators.This PR undoes that, so now we have:
In `values.yaml:
administrator.usernameandauth.administratorsas separate values, and edits to
statefulset.yaml,secrets.yamlandmetacat.propertiesto support these changesFinally, I found a bug resulting from the recent change to the docker base image (
tomcat:8.5.90-jre8-temurin-jammy) - this necessitated an upgrade to python 3, which broke the password hashing indocker-entrypoint.sh, so that's been fixed too.