Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the advance search servlet. #1744

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Remove the advance search servlet. #1744

merged 2 commits into from
Nov 29, 2023

Conversation

taojing2002
Copy link
Contributor

This is a simple PR since I just removed the advance search servlet, which used the obsoleted path query.

artntek
artntek requested changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@artntek artntek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 2 things:

  1. can this ant target be removed?

  2. there are a lot of usages in jsp files within lib/style/skins. Can these be removed? Or better still, is it time to get rid of lib/style/skins altogether??

@taojing2002
Copy link
Contributor Author

  1. Good catch! I removed the target on the build.xml.
  2. I already input a ticket to clear out that directory two weeks ago:
    Clean up lib/style/skins directory #1741

@taojing2002 taojing2002 merged commit eb7eed6 into develop Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artntek artntek artntek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@taojing2002 @artntek