Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update entity name on replace doesn't work sometimes #1394

Closed
laurenwalker opened this issue May 19, 2020 · 4 comments
Closed

Update entity name on replace doesn't work sometimes #1394

laurenwalker opened this issue May 19, 2020 · 4 comments
Labels
bug no change Issues that require no code change. i.e. rejected suggestions, false bugs, etc.

Comments

@laurenwalker
Copy link
Member

When a user replaces a file and the file name has changed, I wonder if we want to update the entity name in the metadata as well? We do update the fileName in the system metadata. Typically, these file/entity names match, but they don't have to.
Thoughts?

@laurenwalker
Copy link
Member Author

Actually, after testing some more, it seems that the entity name does get updated, but sometimes it doesn't work. I haven't found the exact conditions under which it doesn't work, but I will update this if I find them.

@laurenwalker laurenwalker changed the title Update entity name on replace? Update entity name on replace doesn't work sometimes May 19, 2020
@jeanetteclark
Copy link
Collaborator

I thought that I had opened an issue for removing the ability to edit the entityName entirely in metacatUI. Often users mis-interpret this field, and IMO it should be the same name as what exists in the system metadata.

Because of this, my vote is to update the entityName in the metadata to match the fileName in the sysmeta

@mbjones
Copy link
Member

mbjones commented May 19, 2020

That is not the main intent of that field, although I agree it sometimes contains filenames. The filename for an object in EML goes in e.g., dataTable/physical/objectName, and that should definitely match system metadata. The entity name is meant to differentiate entities, sometimes in files that might contain multiple entities. For example, in an excel file named with a physical objectName of "mydata.xls", one might have two entities representing two tabs in the spreadsheet, with the first entityName being "Population Abundance" and the second being "Taxon Codes", or somesuch. Or they might be multiple objects in a NetCDF single file.

In sum, while putting a filename in entityName is fine, it shouldn't be required. I would however fully support that objectName always should properly reflect the same filename that is in sysmeta.

@laurenwalker
Copy link
Member Author

Okay, so perhaps we should never update the entityName when replacing files.

I think we can keep the behavior where the entityName is set to the fileName upon initial upload, just to get the user started.

@laurenwalker laurenwalker added the no change Issues that require no code change. i.e. rejected suggestions, false bugs, etc. label Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug no change Issues that require no code change. i.e. rejected suggestions, false bugs, etc.
Projects
None yet
Development

No branches or pull requests

3 participants