Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media type is being inserted into ./otherEntity/entityType element #1951

Open
gothub opened this issue Jan 27, 2022 · 2 comments
Open

Media type is being inserted into ./otherEntity/entityType element #1951

gothub opened this issue Jan 27, 2022 · 2 comments
Labels

Comments

@gothub
Copy link
Contributor

gothub commented Jan 27, 2022

The media type for data files newly added via the editor is being inserted into the EML //otherEntity/entityType element.

The media type could be entered instead into the EML element //otherEntity/physical/dataFormat/externallyDefinedFormat/formatName

For an example, see

Here is the section inserted by MetacatUI:

<otherEntity id="urn-uuid-bb476d98-f762-41d9-9509-3fca430887a7">
  <entityName>Scooter_blanket.jpg</entityName>
  <entityDescription>Cute dog photo</entityDescription>
  <entityType>image/jpeg</entityType>
</otherEntity>

which instead could be written as:

<otherEntity id="urn-uuid-bb476d98-f762-41d9-9509-3fca430887a7>
  <entityName>Scooter_blanket.jpg</entityName>
  <entityDescription>Cute dog photo</entityDescription>
  <entityType>JPEG Image</entityType>
  <physical>
    <objectName>Scooter_blanket.jpg</objectName>
    <size unit="byte">87616</size>
    <dataFormat>
      <externallyDefinedFormat>
        <formatName>image/jpeg</formatName>
      </externallyDefinedFormat>
    </dataFormat>
  </physical>
</otherEntity>

For further context on how this issue originated, see NCEAS/metadig-checks#64 (comment)

@gothub gothub added the bug label Jan 27, 2022
@jeanetteclark
Copy link
Collaborator

I believe entityType is required for otherEntity elements so something has to go there.

A more broad issue to create physical sections is #450, which I would still love to see implemented

@vchendrix
Copy link
Collaborator

vchendrix commented Jan 28, 2022

@vchendrix adding the <physcial> element seems fine but to make it backwards compatible <entityType/> should still be the mime type. and not a human friendly description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants