Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CatalogSearchView display when there are no results #2111

Closed
robyngit opened this issue Mar 20, 2023 · 1 comment
Closed

Fix CatalogSearchView display when there are no results #2111

robyngit opened this issue Mar 20, 2023 · 1 comment
Assignees
@robyngit
Labels
bug
Milestone
2.25.0

Comments

@robyngit
Copy link
Member

In the new DataCatalogViewWithFilters (see #1520), HTML is not rendered properly when a search has zero results.

When you search for a term that doesn't in exist in a repo that has data:
Screen Shot 2023-03-20 at 12 27 19

When a repository doesn't have any data yet:
Screen Shot 2023-03-20 at 12 28 08
@robyngit robyngit added the bug label Mar 20, 2023
@robyngit robyngit added this to the 2.24.0 milestone Mar 20, 2023
@robyngit robyngit self-assigned this Mar 20, 2023
@robyngit robyngit changed the title Fix DataCatalogViewWithFilters display when there are no results Fix CatalogSearchView display when there are no results Mar 21, 2023
robyngit added a commit that referenced this issue Mar 22, 2023
@robyngit
Handle errors and zero results in CatalogSearch
e82bdb1 
Fixes #2111
@robyngit
Copy link
Member Author

Complete in the feature-#1720-cesium-data-catalog branch. This can be closed when the branch is merged into develop.

No results:
Screen Shot 2023-03-22 at 18 58 54

Error:
Screen Shot 2023-03-22 at 18 58 15

@robyngit robyngit modified the milestones: 2.24.0, 2.25.0 May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robyngit robyngit

Labels
bug
Projects
None yet
Milestone
2.25.0
Development

No branches or pull requests
1 participant
@robyngit