Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CatalogSearchView should navigate back to first page in new search #2112

Closed
robyngit opened this issue Mar 22, 2023 · 1 comment
Closed

CatalogSearchView should navigate back to first page in new search #2112

robyngit opened this issue Mar 22, 2023 · 1 comment
Assignees
Labels
Milestone

Comments

@robyngit
Copy link
Member

Describe the bug
In the new WIP CatalogSearchView, the pager and page part of the URL does not reset when a search term is added to the query. So if an initial query has n pages of results, and you navigate to the last page, then you add a search term that results in < n pages, then the CatalogSearchView stays on page n but that page is empty.

To Reproduce
Steps to reproduce the behavior:

  1. The new Catalog Search is not available on any production repos at the time of writing, so run MetacatUI locally and set the useDeprecatedDataCatalogView config option to false.
  2. In the catalog, search for any term that gives a result with at least a few pages.
  3. Switch to the last page.
  4. Add another search term that gives results, but fewer pages than previously.
  5. See that the list is now empty, and the page hasn't reset to page 1.

Expected behavior
I think the expected behaviour would be for the catalog to switch back to the first page when a new filter/term is added to the search. This should be reflected in the URL as well.

Screenshots
Screen Shot 2023-03-22 at 17 44 00

Additional context
I think this should be resolved before we release the new CatalogSearchView, so this issue blocks #1520 and #1720

@robyngit robyngit added the bug label Mar 22, 2023
@robyngit robyngit added this to the 2.24.0 milestone Mar 22, 2023
@robyngit robyngit self-assigned this Mar 22, 2023
@robyngit
Copy link
Member Author

Fixed in feature-#1720-cesium-data-catalog

@robyngit robyngit modified the milestones: 2.24.0, 2.25.0 May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant